Skip to content

Conversation

@benjamin-stacks
Copy link
Contributor

No description provided.

This is the main change but not fully complete -- memory handling of
shut-down observers is not satisfactory, and the port number must be
handled more flexibly.
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 6.85118% with 2053 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (3d27a91) to head (17e0f3e).

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0/reorg.rs 0.00% 419 Missing ⚠️
stacks-node/src/tests/signer/v0/mod.rs 0.00% 380 Missing ⚠️
stacks-node/src/tests/nakamoto_integrations.rs 0.00% 309 Missing ⚠️
stacks-node/src/tests/test_observer.rs 34.18% 285 Missing ⚠️
stacks-node/src/tests/signer/v0/tenure_extend.rs 0.00% 271 Missing ⚠️
stacks-node/src/tests/neon_integrations.rs 2.54% 115 Missing ⚠️
stacks-node/src/tests/epoch_21.rs 0.00% 76 Missing ⚠️
stacks-node/src/tests/signer/v0/tx_replay.rs 0.00% 72 Missing ⚠️
...tacks-node/src/tests/signer/commands/block_wait.rs 0.00% 47 Missing ⚠️
stacks-node/src/tests/signer/mod.rs 0.00% 20 Missing ⚠️
... and 6 more

❌ Your project check has failed because the head coverage (62.58%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (3d27a91) and HEAD (17e0f3e). Click for more details.

HEAD has 36 uploads less than BASE
Flag BASE (3d27a91) HEAD (17e0f3e)
73 37
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6825       +/-   ##
============================================
- Coverage    78.33%   62.58%   -15.75%     
============================================
  Files          589      590        +1     
  Lines       357076   357941      +865     
============================================
- Hits        279700   224020    -55680     
- Misses       77376   133921    +56545     
Files with missing lines Coverage Δ
stacks-node/src/tests/mod.rs 72.45% <ø> (-13.54%) ⬇️
stacks-node/src/tests/epoch_23.rs 0.00% <0.00%> (ø)
stacks-node/src/tests/stackerdb.rs 0.00% <0.00%> (ø)
stacks-node/src/tests/epoch_24.rs 0.00% <0.00%> (ø)
stacks-node/src/tests/epoch_22.rs 0.00% <0.00%> (ø)
stacks-node/src/tests/epoch_205.rs 0.00% <0.00%> (ø)
stacks-node/src/tests/signer/commands/context.rs 0.00% <0.00%> (-60.00%) ⬇️
stacks-node/src/tests/signer/mod.rs 0.00% <0.00%> (-69.19%) ⬇️
...tacks-node/src/tests/signer/commands/block_wait.rs 0.00% <0.00%> (-23.41%) ⬇️
stacks-node/src/tests/signer/v0/tx_replay.rs 0.00% <0.00%> (ø)
... and 7 more

... and 372 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d27a91...17e0f3e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant