Do not prematurely issue a response if still waiting on block validate response

[jacinta-stacks]

When investigating GSM:
Signer received block proposal S
Submitted S to node for validation
While validating, signer received >70% pre-commits over block S.
Signer immediately issued BlockAccept across S
Signer received block validate Ok, checked against local state: saw reorg of same block-> issued a BlockRejection

Signer should not prematurely issue the original Accept as the node could have responded with a BlockValidateReject.

Fixed and added a test.

[codecov]

Codecov Report

❌ Patch coverage is 6.73575% with 180 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.43%. Comparing base (fab1a15) to head (394d3af).
⚠️ Report is 28 commits behind head on develop.

Files with missing lines	Patch %	Lines
...src/tests/signer/v0/signers_wait_for_validation.rs	0.00%	124 Missing ⚠️
stacks-node/src/tests/signer/v0/reorg.rs	0.00%	21 Missing ⚠️
stacks-node/src/tests/signer/v0/mod.rs	0.00%	16 Missing ⚠️
stacks-node/src/tests/signer/v0/tenure_extend.rs	0.00%	12 Missing ⚠️
stackslib/src/net/api/postblock_proposal.rs	68.75%	5 Missing ⚠️
stacks-signer/src/v0/signer.rs	50.00%	2 Missing ⚠️

❌ Your project status has failed because the head coverage (73.43%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6850      +/-   ##
===========================================
- Coverage    74.44%   73.43%   -1.02%     
===========================================
  Files          593      595       +2     
  Lines       358727   358946     +219     
===========================================
- Hits        267065   263597    -3468     
- Misses       91662    95349    +3687     

Files with missing lines	Coverage Δ
stacks-signer/src/v0/signer.rs	75.36% <50.00%> (-5.98%)	⬇️
stackslib/src/net/api/postblock_proposal.rs	62.20% <68.75%> (-2.30%)	⬇️
stacks-node/src/tests/signer/v0/tenure_extend.rs	0.00% <0.00%> (ø)
stacks-node/src/tests/signer/v0/mod.rs	20.42% <0.00%> (-32.44%)	⬇️
stacks-node/src/tests/signer/v0/reorg.rs	16.58% <0.00%> (-28.12%)	⬇️
...src/tests/signer/v0/signers_wait_for_validation.rs	0.00% <0.00%> (ø)

... and 333 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab1a15...394d3af. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[brice-stacks]

👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.