Fix signer capitulation to account for timing out its local view#6851
Merged
jacinta-stacks merged 5 commits intostacks-network:developfrom Feb 9, 2026
Conversation
…sending an update Signed-off-by: Jacinta Ferrant <236437600+jacinta-stacks@users.noreply.github.com>
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (74.25%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6851 +/- ##
===========================================
- Coverage 74.66% 74.25% -0.42%
===========================================
Files 594 595 +1
Lines 358773 359859 +1086
===========================================
- Hits 267894 267227 -667
- Misses 90879 92632 +1753
... and 75 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
… into bugfix/signers-send-updates-after-timing-out-block
Signed-off-by: Jacinta Ferrant <236437600+jacinta-stacks@users.noreply.github.com>
Signed-off-by: Jacinta Ferrant <236437600+jacinta-stacks@users.noreply.github.com>
… into bugfix/signers-send-updates-after-timing-out-block
aaronb-stacks
approved these changes
Feb 6, 2026
Merged
via the queue into
stacks-network:develop
with commit Feb 9, 2026
0ab58cf
948 of 958 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered this scenario in GSM testing:
All signers receive burn block N, but half see parent_tenure_last_block_height: S+1 and the rest see parent_tenure_last_block_height: S.
Neither side ever capitulated to the appropriate side because in this instance the signer was still signing (timed out and would sign blocks but never updated its view) so it didn't even attempt capitulation. If GSM activated, this would have stalled. In the stall case, it would at least ATTEMPT a capitulation, but it still not have capitulated because in the case where we have a <70% reaching agreement on a view AND no blocks signed (which was exactly this case. A 50% split)...it does not attempt a capitulation. I am wary to mess with the capitulation logic and think its safer to just issue an update if you time out your local view before then also checking for capitulation based on blocking minorities etc.