Skip to content

Remove second cache in bitcoin tests#6852

Merged
wileyj merged 1 commit intostacks-network:developfrom
wileyj:chore/dedupe_bitcoin_test_cache
Feb 5, 2026
Merged

Remove second cache in bitcoin tests#6852
wileyj merged 1 commit intostacks-network:developfrom
wileyj:chore/dedupe_bitcoin_test_cache

Conversation

@wileyj
Copy link
Collaborator

@wileyj wileyj commented Feb 3, 2026

Removes the duplicate cache step in bitcoin-tests that reproduces the already existing test_archive.tar.zst, built only with stacks-node as opposed to the existing (and downloaded) cache built with all binaries.

comparing develop to the branch being PR'ed here (which is develop with the cache step removed) i see both ci runs of bitcoin-tests result in 266 tests to be run.

This branch simply uses the already existing nextest cache that is built for all CI runs in the Create Test Cache job (and is subsequently used for all test runs vs rebuilding).

develop: https://github.com/wileyj/stacks-core/actions/runs/21649775746/job/62412455861#step:7:35
chore/dedupe_bitcoin_test_cache: https://github.com/wileyj/stacks-core/actions/runs/21650652585/job/62415354269#step:6:35

because there are so many tests being run though, both actions will take quite a bit of time to run completely - but it does result in a few minutes saved before the tests start (00:09:45 vs 00:02:07 - 7 minutes and 38 seconds faster).

small improvement, but worth doing.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.39%. Comparing base (1c5bc67) to head (686ae77).
⚠️ Report is 16 commits behind head on develop.

❌ Your project status has failed because the head coverage (73.39%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6852      +/-   ##
===========================================
+ Coverage    68.54%   73.39%   +4.85%     
===========================================
  Files          593      593              
  Lines       358682   358727      +45     
===========================================
+ Hits        245850   263285   +17435     
+ Misses      112832    95442   -17390     

see 386 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5bc67...686ae77. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wileyj wileyj added this pull request to the merge queue Feb 5, 2026
Merged via the queue into stacks-network:develop with commit 68c6703 Feb 5, 2026
316 of 319 checks passed
@wileyj wileyj deleted the chore/dedupe_bitcoin_test_cache branch February 5, 2026 16:08
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants