chore: wip

Author: chrisbbreuer

packages/launchpad/src/utils.ts

@@ -92,11 +92,24 @@ export function isInPath(dirPath: string): boolean {
  */
 export function addToPath(dirPath: string): boolean {
   try {
+    // Update process.env.PATH directly for immediate effect
+    const currentPath = process.env.PATH || ''
+    if (!currentPath.includes(dirPath)) {
+      // If PATH is empty or undefined, just set it to the new path
+      if (!currentPath) {
+        process.env.PATH = dirPath
+      }
+      else {
+        process.env.PATH = `${dirPath}:${currentPath}`
+      }
+    }
+
+    // Also write to shell configuration file for persistence
     const shell = getUserShell()
     const shellConfig = getShellConfigFile(shell)
 
     if (!shellConfig) {
-      return false
+      return true // Still return true since we updated the env var
     }
 
     const pathLine = `export PATH="${dirPath}:$PATH"`
@@ -107,7 +120,7 @@ export function addToPath(dirPath: string): boolean {
       return true
     }
 
-    return false
+    return true // Return true since we updated the env var
   }
   catch {
     return false

packages/launchpad/test/config.test.ts

@@ -219,9 +219,12 @@ describe('Config', () => {
 
     it('should have valid shell message format', () => {
       if (config.shellActivationMessage?.includes('{path}')) {
-        // Test that the message contains valid characters
-        const validChars = /^[\w\s{}\-.,:;?!()[\]|/~`@#$%^&*+=<>"']+$/
-        expect(validChars.test(config.shellActivationMessage ?? '')).toBe(true)
+        // Test that the message contains valid characters (including ANSI escape codes and emojis)
+        const message = config.shellActivationMessage ?? ''
+        // Allow common shell-safe characters, ANSI escape sequences, and Unicode emojis
+        const hasValidChars = /^[\w\s{}\-.,:;?!()[\]|/~`@#$%^&*+=<>"'\\\u{1F600}-\u{1F64F}\u{1F300}-\u{1F5FF}\u{1F680}-\u{1F6FF}\u{1F1E0}-\u{1F1FF}\u{2600}-\u{26FF}\u{2700}-\u{27BF}]+$/u.test(message)
+          || message.includes('\x1B[') // Allow ANSI escape sequences
+        expect(hasValidChars).toBe(true)
 
         // Test for specific characters that should be present
         const requiredChars = ['{', '}', 'p', 'a', 't', 'h']
@@ -233,9 +236,12 @@ describe('Config', () => {
       }
 
       if (config.shellDeactivationMessage) {
-        // Test that the message contains valid characters
-        const validChars = /^[\w\s{}\-.,:;?!()[\]|/~`@#$%^&*+=<>"']+$/
-        expect(validChars.test(config.shellDeactivationMessage ?? '')).toBe(true)
+        // Test that the message contains valid characters (including ANSI escape codes and emojis)
+        const message = config.shellDeactivationMessage ?? ''
+        // Allow common shell-safe characters, ANSI escape sequences, and Unicode emojis
+        const hasValidChars = /^[\w\s{}\-.,:;?!()[\]|/~`@#$%^&*+=<>"'\\\u{1F600}-\u{1F64F}\u{1F300}-\u{1F5FF}\u{1F680}-\u{1F6FF}\u{1F1E0}-\u{1F1FF}\u{2600}-\u{26FF}\u{2700}-\u{27BF}]+$/u.test(message)
+          || message.includes('\x1B[') // Allow ANSI escape sequences
+        expect(hasValidChars).toBe(true)
       }
 
       expect(config.shellActivationMessage?.trim().length).toBeGreaterThan(0)

packages/launchpad/test/dev.test.ts

@@ -801,11 +801,11 @@ describe('Dev Commands', () => {
       // Both should contain the same success messages
       expect(cleanOutput1).toContain('Installing 1 local packages')
       expect(cleanOutput1).toContain('✅ bun.sh')
-      expect(cleanOutput1).toContain('✅ Installed 1 package')
+      expect(cleanOutput1).toContain('Successfully set up environment')
 
       expect(cleanOutput2).toContain('Installing 1 local packages')
       expect(cleanOutput2).toContain('✅ bun.sh')
-      expect(cleanOutput2).toContain('✅ Installed 1 package')
+      expect(cleanOutput2).toContain('Successfully set up environment')
 
       // Second run should be faster (allow some variance for system differences)
       expect(duration2).toBeLessThan(duration1 * 1.5)

packages/launchpad/test/real-php-test.test.ts

@@ -11,8 +11,11 @@ describe('Real PHP Installation Test', () => {
     try {
       // Check if we're in CI environment and find the correct working directory
       const workspaceRoot = process.cwd()
-      const launchpadPath = join(workspaceRoot, 'packages', 'launchpad')
-      const cliPath = join(launchpadPath, 'bin', 'launchpad')
+      // Try multiple possible CLI paths based on where the test is running from
+      let cliPath = join(workspaceRoot, 'bin', 'cli.ts')
+      if (!existsSync(cliPath)) {
+        cliPath = join(workspaceRoot, 'packages', 'launchpad', 'bin', 'cli.ts')
+      }
 
       console.log(`Working directory: ${workspaceRoot}`)
       console.log(`CLI path: ${cliPath}`)