do not leave comment if custom version has not been set #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meorphis
commented
Aug 2, 2025
meorphis
commented
we're getting some bad comments on PRs saying the version has been changed when it hasn't. we should instead be comparing the bumped version with the PR title (not the manifest version, since the manifest could be behind if we failed to create the release commit earlier)
meorphis
added a commit
that referenced
this pull request
Aug 11, 2025
* Revert "do not leave comment if custom version has not been set (#212)" This reverts commit e163d6f. * fork base and add release commit atomically * fix --------- Co-authored-by: meorphis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.