feat: new hono package #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-casey
suggested changes
Dec 11, 2024
Contributor
matt-casey
left a comment
matt-casey
left a comment
There was a problem hiding this comment.
LGTM
A lot of the comments can wait until we do a more thorough reworking of stl-api, but the base path issue needs to be looked into
packages/hono/src/honoPlugin.ts
Outdated
Comment on lines
35
to
37
| return app.all("*", async (c) => { | ||
| try { | ||
| const match = routeMatcher.match(c.req.method, c.req.path); |
Contributor
There was a problem hiding this comment.
I think we may need to check to see if the stl-api definition has any base paths defined
Contributor
As far as publishing, I believe the CI job does that, but you can also manually run the It iterates over everything inside of for (const dir of packageDirs) {
await gitPublish(dir, { dryRun });
} |
matt-casey
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new hono package, similar to the express / next packages. tested it locally, but we should write better tests eventually