Implemented Into<[u64;2]> for Xorshift128Plus#5
Merged
IvanUkhov merged 1 commit intostainless-steel:mainfrom Oct 10, 2025
Merged
Implemented Into<[u64;2]> for Xorshift128Plus#5IvanUkhov merged 1 commit intostainless-steel:mainfrom
IvanUkhov merged 1 commit intostainless-steel:mainfrom
Conversation
Member
|
Hello, thank you for the PR. This crate is meant to be minimalistic. I would not want to add that dependency. However, I would be open to opening the internal state if there is interest. If you are up for this, please go ahead and add |
Contributor
Author
|
Thank your for your response. I am not used to contributing, I amended my commit. I hope this is the "right way" if not let me know! |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Since the internals fields of Xorshift128Plus can not be read and thus restored using a new([u64;2]) I just added support for Serde.
I am working on a seed based procedural generation tool and the ability to store the generator state and reload it is required.
Thank you for your consideration.