Merged
Conversation
Dearest Reviewer, Issue stalwartlabs#90 brought up the issue that if there was no newline. the user provided an easy reproduction case. I was able to track it down to the parse raw function. The issue is that the loop hits the end of the string and returns Empty. However, if there is a start offset then some characters were found. This code just checks the offset after the loop. If this is not the correct behavior please close. Thanks for your time Becker
sbeckeriv
added a commit
to sbeckeriv/mail-parser
that referenced
this pull request
Mar 1, 2025
Dearest Reviewer, While creating PR stalwartlabs#102 I tried running the fuzz command and found it failing. It looks like the functions were made private and parse headers arguments were updated. I dont know if this is a complete update or what is covered but it does get `cargo +nightly fuzz run mail_parser` working again. Thanks for your time. Becker
Merged
mdecimus
reviewed
Mar 2, 2025
mdecimus
pushed a commit
that referenced
this pull request
Mar 2, 2025
* fix-fuzz-targets Dearest Reviewer, While creating PR #102 I tried running the fuzz command and found it failing. It looks like the functions were made private and parse headers arguments were updated. I dont know if this is a complete update or what is covered but it does get `cargo +nightly fuzz run mail_parser` working again. Thanks for your time. Becker * readd space
Add break instead of duplicating code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dearest Reviewer,
Issue #90 brought up an issue that if there was no newline it would fail. the user provided an easy reproduction case. I was able to track it down to the parse raw function.
The issue is that the loop hits the end of the string and returns Empty. However, if there is a start offset then some characters were found. This code just checks the offset after the loop.
If this is not the correct behavior please close.
Thanks for your time
Becker