Revert csv parsing empty data to return empty arrays #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Fixes #800.
New CSV parsing in #799 threw errors when attempting to parse csv content with no data. This can arise legitimately, for example, if
iter_sampling=0andsave_warmup=False; which results in no draw lines (although the header line is present). In previous versions, empty data would result in empty numpy arrays. This change reverts the csv parsing of empty data to the previous behavior.For clarity:
the
cmdstanpy.utils.stancsv.csv_bytes_list_to_numpy(...)function now has the following behavior:(0,)is returned(0, num_cols)is returnedThis PR also changes some stancsv unit tests to match the desired behavior and adds a test to
test_samplefor the case of no sampling draws.Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): myself
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: