Skip to content

Conversation

@amas0
Copy link
Collaborator

@amas0 amas0 commented Aug 22, 2025

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This PR bumps the required Python version of the library to 3.9. Resolves #802 .

Also uses the 3.9 features of typing with generics for dict, list, tuple and dictionary unions with |.

I also removed 3.8 testing from the Github workflow for CI/CD and added 3.13 (I think the way I did it is correct? I've not used it before).

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): myself

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@amas0 amas0 changed the title Remove Python 3.8 support Draft: Remove Python 3.8 support Aug 22, 2025
@amas0 amas0 changed the title Draft: Remove Python 3.8 support Remove Python 3.8 support Aug 22, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file got processed with string normalization turned on before you updated the pyproject.toml -- mind reverting those changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, good catch.

As a side note, we're pretty inconsistent throughout the library with string quoting. It'd be a big edit, but is there any desire to just go ahead and normalize everything to either single or double quotes and be consistent going forward?

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@WardBrian WardBrian merged commit 54a0416 into stan-dev:develop Aug 25, 2025
16 checks passed
@WardBrian
Copy link
Member

As a side note, we're pretty inconsistent throughout the library with string quoting. It'd be a big edit, but is there any desire to just go ahead and normalize everything to either single or double quotes and be consistent going forward?

I wouldn't be opposed to doing this in it's own PR, but the setting disabling string normalization predates me so we may also want to ask @mitzimorris if she minds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removal of support for end-of-life Python versions

2 participants