Skip to content

Conversation

@WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Removes the remaining deprecated code paths and closes #685. I took the somewhat-conservative latest-plus-two-versions path here, so I left checks for 2.35/2.36, but deleted any older than that.

This also clears the path for us to tackle #713 and #714

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian linked an issue Nov 6, 2025 that may be closed by this pull request
Copy link
Collaborator

@amas0 amas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I think this means we can also remove the test and testing csv mentioned in #805 ; which, if I recall, could only be produced by a cmdstan version we are no longer supporting.

@WardBrian
Copy link
Member Author

The change to make #805 go away was made in 2.35 I believe, so it's just within the current-minus-two range.

@WardBrian WardBrian merged commit 09f39de into develop Nov 6, 2025
16 checks passed
@WardBrian WardBrian deleted the 2.0-min-cmdstan branch November 6, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iter_warmpup=0 and fixed_param=True will always fail for stan 2.34.1 Remove support for CmdStan pre-2.34 in a future version

3 participants