Skip to content

Conversation

@andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

This PR enables running the OpenCL tests in CI by using the POCL implementation CPU-based OpenCL. This also identified a handful of errors with the existing tests that I've fixed.

I haven't added Windows just yet, still have to see if there's a relatively simple way to include it.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo looks good, ty! @jgabry any comments or good to merge?

@jgabry
Copy link
Member

jgabry commented Jan 6, 2025

I think OK to merge unless @andrjohns has anything else to push

@andrjohns andrjohns merged commit 369b93a into master Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants