Skip to content

Conversation

@andrjohns
Copy link
Collaborator

@andrjohns andrjohns commented Mar 4, 2025

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

The R-devel tests are currently failing with a grepl error:

Error in grepl(as.character(pattern), x, ignore.case, FALSE, perl, fixed,  : 
  NA in coercion to boolean

It looks like this is caused by a couple of the expect_match calls accidentally including the input variable twice:

expect_match(out[1], " variable", out[1])

The second out[1] is assumed to be a boolean argument and R tries to convert it. I think it's only started to error recently since they've been majorly reworking the handling of boolean types in R's C API (but that's just a guess)

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! will go ahead and merge.

@jgabry jgabry merged commit 2fee6ca into master Mar 4, 2025
11 checks passed
@jgabry jgabry deleted the fix-test-errors branch March 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants