Skip to content

Conversation

@katrinabrock
Copy link
Contributor

@katrinabrock katrinabrock commented Apr 15, 2025

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Precursor to #1022 .

To properly handle options when cmdstanr is provided a pre-compiled binary, we need to base arg checking on the cpp args and cmdstan version that the binary was complied with. This version may or may not be the same as the version currently set. This PR does not solve this problem completely. It is a precursor to the solution by at least storing a cmdstan version value in the model object.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry
Copy link
Member

jgabry commented Apr 15, 2025

Thanks! This looks good to me. @andrjohns any issues with this on your end?

Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM, thanks!

@jgabry
Copy link
Member

jgabry commented Apr 17, 2025

Ok great will go ahead and merge since everything is passing.

@jgabry jgabry merged commit 541f36c into stan-dev:master Apr 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants