Skip to content

Conversation

@katrinabrock
Copy link
Contributor

@katrinabrock katrinabrock commented Apr 28, 2025

Also

  • Move some helper functions out of model.R into new file
  • Add tests for newly added functions

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

  • Move a few cpp option related functions into their own file (these are unchanged)
  • Add new parser functions and tests (several of these functions are not yet used outside of tests, but will be used with new cpp option logic)

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Also
- Move some helper functions out of model.R into new file
- Add tests for newly added functions
@katrinabrock katrinabrock marked this pull request as draft April 28, 2025 13:07
@katrinabrock katrinabrock marked this pull request as ready for review April 29, 2025 09:17
Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Few little things that are mostly just cleanup, but overall good

Comment on lines +84 to +85
for (i in seq_along(cpp_options)) {
option_name <- names(cpp_options)[i]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (i in seq_along(cpp_options)) {
option_name <- names(cpp_options)[i]
cpp_option_names = names(cpp_options)
for (i in seq_along(cpp_options)) {
option_name <- cpp_option_names[i]

@katrinabrock katrinabrock requested a review from SteveBronder May 2, 2025 10:14
@katrinabrock
Copy link
Contributor Author

@jgabry can you merge this one also?

@jgabry
Copy link
Member

jgabry commented May 8, 2025

Merging now. Thanks @katrinabrock! And thanks @SteveBronder for reviewing.

@jgabry jgabry merged commit d5b394b into stan-dev:master May 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants