Skip to content

Conversation

@katrinabrock
Copy link
Contributor

@katrinabrock katrinabrock commented Jun 6, 2025

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Please describe the purpose of the pull request.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@katrinabrock katrinabrock marked this pull request as draft June 6, 2025 12:30
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.22%. Comparing base (c57888e) to head (bafae1f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files          14       14           
  Lines        5973     5973           
=======================================
  Hits         5210     5210           
  Misses        763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katrinabrock
Copy link
Contributor Author

@jgabry can you tell if the OSX failures are related to my changes? especially the release one I'm not sure

@katrinabrock katrinabrock marked this pull request as ready for review June 6, 2025 13:28
@jgabry
Copy link
Member

jgabry commented Jun 6, 2025

Hmm yeah that Mac release failure is pretty strange, haven't seen that before. The devel one almost certainly isn't related to your change. I'd also be surprised if the release one is. I just set those two to run again since sometimes the issues resolve themselves. If they fail again I can test the changes locally on a Mac too.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jgabry
Copy link
Member

jgabry commented Jun 6, 2025

Also @katrinabrock, at this point we should add you to the DESCRIPTION file as a contributor! If you want you can add that to this PR. If you'd rather not be listed that's fine too of course.

@jgabry
Copy link
Member

jgabry commented Jun 6, 2025

Also @katrinabrock, at this point we should add you to the DESCRIPTION file as a contributor! If you want you can add that to this PR. If you'd rather not be listed that's fine too of course.

I think this is ready to merge. Did you want to include the DESCRIPTION file in this PR?

@katrinabrock
Copy link
Contributor Author

@jgabry you can go ahead and merge. we can update the description file later.

@jgabry jgabry merged commit 5f2a8c8 into stan-dev:master Jun 11, 2025
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read_cmdstan_csv fails with unhelpful error if tilde expansion is needed (linux)

3 participants