-
-
Notifications
You must be signed in to change notification settings - Fork 66
fix read_cmdstan_csv tilde issue #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1098 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 14 14
Lines 5973 5973
=======================================
Hits 5210 5210
Misses 763 763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jgabry can you tell if the OSX failures are related to my changes? especially the |
|
Hmm yeah that Mac release failure is pretty strange, haven't seen that before. The devel one almost certainly isn't related to your change. I'd also be surprised if the release one is. I just set those two to run again since sometimes the issues resolve themselves. If they fail again I can test the changes locally on a Mac too. |
jgabry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
|
Also @katrinabrock, at this point we should add you to the DESCRIPTION file as a contributor! If you want you can add that to this PR. If you'd rather not be listed that's fine too of course. |
I think this is ready to merge. Did you want to include the DESCRIPTION file in this PR? |
|
@jgabry you can go ahead and merge. we can update the description file later. |
Submission Checklist
Summary
Please describe the purpose of the pull request.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: