Skip to content

Conversation

@yoshidk6
Copy link
Contributor

@yoshidk6 yoshidk6 commented Sep 18, 2025

Address "Rd \link{} targets" issues raised in CRAN check results.
@noRd and @exportS3Method NULL were added for errors from roxygen2 regarding S3 methods (but better to consider exporting them?) r-lib/roxygen2#1589

There seem to be two other issues causing CMD Check errors:

@jgabry
Copy link
Member

jgabry commented Sep 18, 2025

Thanks for the PR! Looks OK at first glance, but I'll let @bgoodri also take a look.

@yoshidk6
Copy link
Contributor Author

yoshidk6 commented Sep 18, 2025

Thank you for the prompt response! May I also ask if the team is working toward addressing CRAN feedback (rstanarm to be archived by Sep 30)? I have a package that heavily relies on rstanarm (https://github.com/genentech/BayesERtools/) and would love to keep it on CRAN. I'm also happy to contribute if there is anything I can do to help.

@jgabry
Copy link
Member

jgabry commented Sep 18, 2025

We won't let rstanarm get removed from CRAN. @bgoodri I assume you got an email from CRAN about this? When I look at the rstanarm results it seems like it's mainly some NOTES that need to be fixed.

@yoshidk6
Copy link
Contributor Author

Fantastic to hear! I just run macbuilder check for this pull request version and and it seems to return clean.

@jgabry
Copy link
Member

jgabry commented Sep 19, 2025

Great! thanks for checking macbuilder.

@yoshidk6
Copy link
Contributor Author

Hi! Wanted to check if there is any updates on rstanarm CRAN updates, as it's less than a week until the scheduled archival date? Would it help to open an issue?

@jgabry
Copy link
Member

jgabry commented Sep 24, 2025

I've talked with @bgoodri (the maintainer) and he will submit it on time. Thanks for checking in! 

@yoshidk6
Copy link
Contributor Author

Amazing thanks!!

@bgoodri bgoodri merged commit cfe7711 into stan-dev:master Sep 28, 2025
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants