-
-
Notifications
You must be signed in to change notification settings - Fork 137
Fix documentations to address CRAN NOTEs #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! Looks OK at first glance, but I'll let @bgoodri also take a look. |
|
Thank you for the prompt response! May I also ask if the team is working toward addressing CRAN feedback (rstanarm to be archived by Sep 30)? I have a package that heavily relies on rstanarm (https://github.com/genentech/BayesERtools/) and would love to keep it on CRAN. I'm also happy to contribute if there is anything I can do to help. |
|
We won't let rstanarm get removed from CRAN. @bgoodri I assume you got an email from CRAN about this? When I look at the rstanarm results it seems like it's mainly some NOTES that need to be fixed. |
|
Fantastic to hear! I just run macbuilder check for this pull request version and and it seems to return clean. |
|
Great! thanks for checking macbuilder. |
|
Hi! Wanted to check if there is any updates on rstanarm CRAN updates, as it's less than a week until the scheduled archival date? Would it help to open an issue? |
|
I've talked with @bgoodri (the maintainer) and he will submit it on time. Thanks for checking in! |
|
Amazing thanks!! |
Address "Rd \link{} targets" issues raised in CRAN check results.
@noRdand@exportS3Method NULLwere added for errors from roxygen2 regarding S3 methods (but better to consider exporting them?) r-lib/roxygen2#1589There seem to be two other issues causing CMD Check errors:
attr(X, "contrasts")not working properly (addressed in Use rstantools - Fix Build/Export Errors #625 ?)expect_equal(l$estimates, l2$estimates)