Skip to content

Remove a few redundant signatures #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Remove a few redundant signatures #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75d3f8
Remove redundant signatures
WardBrian Feb 9, 2022
440c44d
Remove duplicate complex - complex
WardBrian Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/frontend/Canonicalize.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@ open Ast
open Deprecation_analysis

type canonicalizer_settings =
{ deprecations: bool
; parentheses: bool
; braces: bool
; (* TODO: NYI. Really for the pretty printer but it makes sense to live here *)
inline_includes: bool }
{deprecations: bool; parentheses: bool; braces: bool; inline_includes: bool}

let all =
{deprecations= true; parentheses= true; inline_includes= true; braces= true}
Expand Down
13 changes: 2 additions & 11 deletions src/middle/Stan_math_signatures.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,6 @@ let () =
add_unqualified ("distance", ReturnType UReal, [URowVector; URowVector], SoA) ;
add_unqualified ("distance", ReturnType UReal, [UVector; URowVector], SoA) ;
add_unqualified ("distance", ReturnType UReal, [URowVector; UVector], SoA) ;
add_unqualified ("divide", ReturnType UComplex, [UComplex; UReal], AoS) ;
add_unqualified ("divide", ReturnType UComplex, [UComplex; UComplex], AoS) ;
add_unqualified ("divide", ReturnType UInt, [UInt; UInt], SoA) ;
add_unqualified ("divide", ReturnType UReal, [UReal; UReal], SoA) ;
Expand Down Expand Up @@ -1668,7 +1667,6 @@ let () =
("multinomial_logit_rng", ReturnType (UArray UInt), [UVector; UInt], AoS) ;
add_unqualified
("multinomial_rng", ReturnType (UArray UInt), [UVector; UInt], AoS) ;
add_unqualified ("multiply", ReturnType UComplex, [UComplex; UReal], AoS) ;
add_unqualified ("multiply", ReturnType UComplex, [UComplex; UComplex], AoS) ;
add_unqualified ("multiply", ReturnType UInt, [UInt; UInt], SoA) ;
add_unqualified ("multiply", ReturnType UReal, [UReal; UReal], SoA) ;
Expand Down Expand Up @@ -2058,15 +2056,8 @@ let () =
add_unqualified
("sub_row", ReturnType URowVector, [UMatrix; UInt; UInt; UInt], SoA) ;
List.iter
~f:(fun i ->
add_unqualified
( "subtract"
, ReturnType (List.nth_exn bare_types i)
, [List.nth_exn bare_types i; List.nth_exn bare_types i]
, SoA ) )
(List.range 0 bare_types_size) ;
add_unqualified ("subtract", ReturnType UComplex, [UComplex; UReal], AoS) ;
add_unqualified ("subtract", ReturnType UComplex, [UComplex; UComplex], AoS) ;
~f:(fun x -> add_unqualified ("subtract", ReturnType x, [x; x], SoA))
bare_types ;
add_unqualified ("subtract", ReturnType UVector, [UVector; UReal], SoA) ;
add_unqualified ("subtract", ReturnType URowVector, [URowVector; UReal], SoA) ;
add_unqualified ("subtract", ReturnType UMatrix, [UMatrix; UReal], SoA) ;
Expand Down
2 changes: 0 additions & 2 deletions test/integration/bad/compound-assign/stanc.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,6 @@ Ill-typed arguments supplied to assignment operator *=: lhs has type row_vector
(real, real) => void
(vector, int) => void
(vector, real) => void
(complex, int) => void
(complex, real) => void
(complex, complex) => void
(row_vector, int) => void
(row_vector, real) => void
Expand Down
7 changes: 0 additions & 7 deletions test/integration/bad/stanc.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,8 +765,6 @@ Ill-typed arguments supplied to infix operator -. Available signatures:
(real, vector) => vector
(vector, real) => vector
(vector, vector) => vector
(complex, real) => complex
(complex, complex) => complex
(complex, complex) => complex
(real, row_vector) => row_vector
(row_vector, real) => row_vector
Expand Down Expand Up @@ -1493,7 +1491,6 @@ Ill-typed arguments supplied to infix operator /. Available signatures:
(int, int) => int
(real, real) => real
(vector, real) => vector
(complex, real) => complex
(complex, complex) => complex
(row_vector, real) => row_vector
(matrix, real) => matrix
Expand All @@ -1515,7 +1512,6 @@ Ill-typed arguments supplied to infix operator /. Available signatures:
(int, int) => int
(real, real) => real
(vector, real) => vector
(complex, real) => complex
(complex, complex) => complex
(row_vector, real) => row_vector
(matrix, real) => matrix
Expand Down Expand Up @@ -1691,7 +1687,6 @@ Ill-typed arguments supplied to infix operator *. Available signatures:
(real, vector) => vector
(vector, real) => vector
(matrix, vector) => vector
(complex, real) => complex
(complex, complex) => complex
(real, row_vector) => row_vector
(row_vector, real) => row_vector
Expand All @@ -1717,8 +1712,6 @@ Ill-typed arguments supplied to infix operator -. Available signatures:
(real, vector) => vector
(vector, real) => vector
(vector, vector) => vector
(complex, real) => complex
(complex, complex) => complex
(complex, complex) => complex
(real, row_vector) => row_vector
(row_vector, real) => row_vector
Expand Down
4 changes: 0 additions & 4 deletions test/integration/signatures/stan_math_signatures.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3917,7 +3917,6 @@ Display all Stan math signatures exposed in the language
divide(int, int) => int
divide(real, real) => real
divide(vector, real) => vector
divide(complex, real) => complex
divide(complex, complex) => complex
divide(row_vector, real) => row_vector
divide(matrix, real) => matrix
Expand Down Expand Up @@ -14517,7 +14516,6 @@ Display all Stan math signatures exposed in the language
multiply(real, vector) => vector
multiply(vector, real) => vector
multiply(matrix, vector) => vector
multiply(complex, real) => complex
multiply(complex, complex) => complex
multiply(real, row_vector) => row_vector
multiply(row_vector, real) => row_vector
Expand Down Expand Up @@ -26164,8 +26162,6 @@ Display all Stan math signatures exposed in the language
subtract(real, vector) => vector
subtract(vector, real) => vector
subtract(vector, vector) => vector
subtract(complex, real) => complex
subtract(complex, complex) => complex
subtract(complex, complex) => complex
subtract(real, row_vector) => row_vector
subtract(row_vector, real) => row_vector
Expand Down