Add a transformation to make transition relation right-total#521
Open
Po-Chun-Chien wants to merge 3 commits intomainfrom
Open
Add a transformation to make transition relation right-total#521Po-Chun-Chien wants to merge 3 commits intomainfrom
Po-Chun-Chien wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
The new transformation also has a surprising impact on solving performance. $ ./pono --use-rel-ts --ensure-trans-total --bound 2000000000 --engine ind zipcpu-busdelay-p10.btor2
unsat
b0
$ ./pono --bound 2000000000 --engine ind zipcpu-busdelay-p10.btor2
# no answer after 900 s
$ ./pono --ensure-trans-total --bound 2000000000 --engine ind zipcpu-busdelay-p10.btor2
# no answer after 900 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a procedure that transforms a partial transition relation to a right-total one.
Some model-checking algorithms (such as the interpolation-based ones
interp,ismc, anddar; recall #457) require the transition relation to be total.For example, the invariant check for this Btor2 instance fails without the transformation:
Note that the auxiliary variable introduced by this transformation has to be removed from the invariant (cofactoring on
valid = true) if we later want to export it as a correctness witness.