Require a list or set in check-sat-assuming through Python interface#297
Open
Require a list or set in check-sat-assuming through Python interface#297
Conversation
yoni206
approved these changes
Jan 24, 2022
Collaborator
yoni206
left a comment
yoni206
left a comment
There was a problem hiding this comment.
Great, thanks for this!
Collaborator
Author
|
Thanks for the review! The cvc5 tests are failing because I lost my file hosting where it downloaded pre-compiled versions from. I’ll look into fixing this and then will merge. |
Collaborator
|
Cool. |
Collaborator
Author
|
Sorry for the slow response! Good idea. I think that branch protection is already on, but it looks like you can still override it. Let me know if there's something else I should change. |
Collaborator
|
Is this turned on?
https://stackoverflow.com/a/58655352/1364765
… On Feb 1, 2022, at 4:17 AM, makaimann ***@***.***> wrote:
Sorry for the slow response! Good idea. I think that branch protection is already on, but it looks like you can still override it. Let me know if there's something else I should change.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be easy to accidentally pass a single term to check_sat_assuming and not get an error. There was no error because terms are iterable, so it adds all the children as assumptions. However, this is typically not the desired behavior and can be very confusing.