Conversation
Collaborator
|
Is there something you could add to CI for this? |
Collaborator
|
why python2? (python2 is no longer supported -- no bug fixes or changes) |
Collaborator
Author
|
This was requested for a project using Python 2 :P We don’t have to merge this. However, because it’s such a small change, what do you think about keeping it with a message saying Python2 isn’t officially supported? Then we could also justify not adding it to CI haha. |
Collaborator
|
:) |
yoni206
previously approved these changes
May 7, 2022
Collaborator
|
yeah, a message would be nice that python2 is not officially supported. |
ahmed-irfan
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.