Skip to content

added lemmas to tsv even without verbose output format option #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added lemmas to tsv even without verbose output format option #1485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/edu/stanford/nlp/tagger/maxent/MaxentTagger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,8 +1435,16 @@ private static String getTsvWords(boolean verbose, boolean outputLemmas,
throw new IllegalArgumentException("Expected HasTags, got " +
hw.getClass());
}
sb.append(word);
sb.append('\t');
if (outputLemmas) {
String lemma = ((HasLemma) hw).lemma();
Copy link
Contributor

@AngledLuffa AngledLuffa Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you check that it is a HasLemma here first?

Copy link
Contributor Author

@churow churow Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed original use of HasTag without check pattern.
HasWord, HasTag & HasLemma are implemented through src/edu/stanford/nlp/ling/AbstractToken.java

Copy link
Contributor

@AngledLuffa AngledLuffa Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. However, the assumption is that every class that comes through the tagger will be both HasWord and HasTag, whereas if the tagger is using the WordTag class, there may not be a Lemma.

sb.append(lemma);
sb.append("\t");
}
String tag = ((HasTag) hw).tag();
sb.append(word).append('\t').append(tag).append('\n');
sb.append(tag);
sb.append('\n');
}
sb.append('\n');
return sb.toString();
Expand Down