#479: on_table_exists=skip option for table materialization#481
#479: on_table_exists=skip option for table materialization#481damian3031 merged 1 commit intostarburstdata:masterfrom
Conversation
|
added a change to use "CREATE TABLE IF NOT EXISTS" to do the skipping instead of "SELECT 1" this makes it so that the generated SQL is more useful. |
damian3031
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Some remarks:
- Remove .
changes/1.10.0.mdfile and revert changes toCHANGELOG.md. Instead, add a changie file by running changie new. - Squash commits into a single one.
- Rebase onto master, as CI failures have been fixed there.
- Install and run pre-commit checks before committing your changes.
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
implement table materialization option on_table_exists=skip to allow user to skip a model if the target relation already exists.
|
@damian3031 thank you for your feedback. i believe i have resolved the issues you raised. i've run tox -r and pre-commit run --all-files and the tools seem happy. i am also happy to add documentation. but it wasn't clear to me where to add the documentation. |
sorry for the delay. I need to do some administrative formalities before I can contribute to the doc project. I will take care of those formalities soon and tag you in a PR in two weeks or so. |
|
@damian3031 tagged you in the docs.getdbt.com PR. |
implements on_table_exists=skip option
instead of creating the table, it simply executes "select 1"resolves #479
As requested by @damian3031 in his feedback, a revised checklist: