Skip to content

optimize IsValidGuid to be GC-free #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bfihl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize IsValidGuid to be GC-free #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Eflatun.SceneReference/Packages/com.eflatun.scenereference/Runtime/Utility/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,26 @@ public static string BeforeLast(this string source, char chr)
/// <summary>
/// Returns if the given <paramref name="guid"/> is valid. A valid GUID is 32 chars of hexadecimals.
/// </summary>
public static bool IsValidGuid(this string guid) =>
guid.Length == 32 && guid.ToUpper().All("0123456789ABCDEF".Contains);
public static bool IsValidGuid(this string guid)
{
if (string.IsNullOrEmpty(guid) || guid.Length != 32)
{
return false;
}

for (int i = 0; i < guid.Length; i++)
{
char c = guid[i];
bool isValid = (c >= '0' && c <= '9') || (c >= 'A' && c <= 'F') || (c >= 'a' && c <= 'f');

if (!isValid)
{
return false;
}
}

return true;
}

/// <summary>
/// If the given GUID is null or whitespace returns <see cref="AllZeroGuid"/>. Otherwise returns as-is.
Expand Down