feat: make max traceback entries configurable - #2370
Merged
dorimedini-starkware merged 1 commit intoApr 20, 2026
Merged
Conversation
This was referenced Mar 23, 2026
Collaborator
Author
dorimedini-starkware
requested review from
Yael-Starkware and
YairVaknin-starkware
March 23, 2026 09:10
dorimedini-starkware
marked this pull request as ready for review
March 23, 2026 09:11
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
March 23, 2026 09:18
d952600 to
68f9328
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
March 23, 2026 09:18
760fe16 to
4183462
Compare
|
Benchmark Results for unmodified programs 🚀
|
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
March 23, 2026 09:50
68f9328 to
d2c76cf
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
2 times, most recently
from
March 23, 2026 09:54
4aaeea4 to
7b560d5
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
March 23, 2026 09:54
d2c76cf to
c30cc6e
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
March 23, 2026 10:08
7b560d5 to
4338e99
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
2 times, most recently
from
March 23, 2026 10:38
0db9b90 to
e56b912
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
March 23, 2026 10:38
4338e99 to
de426d9
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
March 23, 2026 10:49
e56b912 to
91a8238
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
2 times, most recently
from
March 23, 2026 10:50
7c90c49 to
6f81c8c
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
2 times, most recently
from
March 23, 2026 10:59
499336b to
8064795
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
March 23, 2026 10:59
6f81c8c to
40f84fa
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
2 times, most recently
from
March 25, 2026 14:04
00e06c3 to
cae34fc
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
March 25, 2026 14:04
90bc97e to
91d5b67
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
March 25, 2026 14:38
cae34fc to
ecfbe1e
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
March 25, 2026 14:38
91d5b67 to
3e6559b
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
March 25, 2026 15:02
ecfbe1e to
e49b830
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
2 times, most recently
from
March 25, 2026 15:15
6431d86 to
ac18e64
Compare
YairVaknin-starkware
approved these changes
Apr 9, 2026
YairVaknin-starkware
left a comment
Collaborator
There was a problem hiding this comment.
@YairVaknin-starkware reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
April 9, 2026 19:15
ac18e64 to
b653bdc
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
2 times, most recently
from
April 13, 2026 06:14
4fded78 to
50877b3
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
April 13, 2026 06:14
b653bdc to
605ab6a
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
April 13, 2026 06:54
50877b3 to
e344647
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
2 times, most recently
from
April 13, 2026 07:31
50c87cb to
e0c2e72
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
April 13, 2026 07:31
e344647 to
48f186d
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
April 13, 2026 08:22
e0c2e72 to
30bf5e0
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_create_and_use_virtualmachineconfig
branch
from
April 13, 2026 08:22
48f186d to
0862f54
Compare
YairVaknin-starkware
approved these changes
Apr 16, 2026
YairVaknin-starkware
left a comment
Collaborator
There was a problem hiding this comment.
@YairVaknin-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).
graphite-app
Bot
changed the base branch from
03-21-feat_create_and_use_virtualmachineconfig
to
graphite-base/2370
April 20, 2026 06:35
dorimedini-starkware
force-pushed
the
graphite-base/2370
branch
from
April 20, 2026 07:18
0862f54 to
50600dd
Compare
dorimedini-starkware
force-pushed
the
03-21-feat_make_max_traceback_entries_configurable
branch
from
April 20, 2026 07:18
30bf5e0 to
71c2029
Compare
Merge activity
|
dorimedini-starkware
deleted the
03-21-feat_make_max_traceback_entries_configurable
branch
April 20, 2026 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TITLE
Description
Description of the pull request changes and motivation.
Checklist
This change is