Skip to content

feat: make max traceback entries configurable - #2370

Merged
dorimedini-starkware merged 1 commit into
mainfrom
03-21-feat_make_max_traceback_entries_configurable
Apr 20, 2026
Merged

feat: make max traceback entries configurable#2370
dorimedini-starkware merged 1 commit into
mainfrom
03-21-feat_make_max_traceback_entries_configurable

Conversation

@dorimedini-starkware

@dorimedini-starkware dorimedini-starkware commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Mar 23, 2026
@dorimedini-starkware
dorimedini-starkware marked this pull request as ready for review March 23, 2026 09:11
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from d952600 to 68f9328 Compare March 23, 2026 09:18
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 760fe16 to 4183462 Compare March 23, 2026 09:18
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.299 ± 0.024 2.271 2.349 1.01 ± 0.01
head big_factorial 2.282 ± 0.019 2.255 2.312 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.209 ± 0.073 2.171 2.416 1.01 ± 0.04
head big_fibonacci 2.181 ± 0.024 2.160 2.239 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.031 ± 0.045 6.986 7.096 1.00
head blake2s_integration_benchmark 7.073 ± 0.067 6.993 7.199 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.297 ± 0.009 2.282 2.312 1.00
head compare_arrays_200000 2.300 ± 0.032 2.278 2.385 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.523 ± 0.007 1.513 1.537 1.01 ± 0.01
head dict_integration_benchmark 1.509 ± 0.006 1.496 1.521 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.187 ± 0.015 1.177 1.228 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.177 ± 0.006 1.169 1.187 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.131 ± 0.055 7.062 7.252 1.00
head integration_builtins 7.159 ± 0.184 7.068 7.676 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.278 ± 0.070 7.199 7.453 1.00
head keccak_integration_benchmark 7.303 ± 0.122 7.203 7.640 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.323 ± 0.008 2.307 2.338 1.01 ± 0.01
head linear_search 2.298 ± 0.021 2.277 2.352 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.689 ± 0.008 1.680 1.701 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.679 ± 0.008 1.670 1.697 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.579 ± 0.014 1.562 1.610 1.01 ± 0.01
head math_integration_benchmark 1.563 ± 0.005 1.557 1.573 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.349 ± 0.006 1.343 1.360 1.01 ± 0.01
head memory_integration_benchmark 1.334 ± 0.008 1.323 1.344 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.629 ± 0.006 1.621 1.643 1.01 ± 0.00
head operations_with_data_structures_benchmarks 1.617 ± 0.004 1.612 1.624 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 522.1 ± 2.4 519.0 527.7 1.00 ± 0.01
head pedersen 521.1 ± 1.5 518.4 523.2 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 656.4 ± 2.6 653.5 662.7 1.01 ± 0.01
head poseidon_integration_benchmark 649.7 ± 1.9 646.0 652.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.767 ± 0.009 1.759 1.786 1.00 ± 0.01
head secp_integration_benchmark 1.759 ± 0.014 1.748 1.796 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 669.6 ± 2.1 667.0 672.4 1.00 ± 0.01
head set_integration_benchmark 666.6 ± 2.6 663.5 673.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.225 ± 0.014 4.205 4.247 1.00 ± 0.01
head uint256_integration_benchmark 4.209 ± 0.028 4.178 4.265 1.00

@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from 68f9328 to d2c76cf Compare March 23, 2026 09:50
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 4aaeea4 to 7b560d5 Compare March 23, 2026 09:54
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from d2c76cf to c30cc6e Compare March 23, 2026 09:54
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 7b560d5 to 4338e99 Compare March 23, 2026 10:08
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 0db9b90 to e56b912 Compare March 23, 2026 10:38
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 4338e99 to de426d9 Compare March 23, 2026 10:38
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from e56b912 to 91a8238 Compare March 23, 2026 10:49
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 7c90c49 to 6f81c8c Compare March 23, 2026 10:50
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 499336b to 8064795 Compare March 23, 2026 10:59
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 6f81c8c to 40f84fa Compare March 23, 2026 10:59
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 00e06c3 to cae34fc Compare March 25, 2026 14:04
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 90bc97e to 91d5b67 Compare March 25, 2026 14:04
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from cae34fc to ecfbe1e Compare March 25, 2026 14:38
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 91d5b67 to 3e6559b Compare March 25, 2026 14:38
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from ecfbe1e to e49b830 Compare March 25, 2026 15:02
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 6431d86 to ac18e64 Compare March 25, 2026 15:15

@YairVaknin-starkware YairVaknin-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@YairVaknin-starkware reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).

@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from ac18e64 to b653bdc Compare April 9, 2026 19:15
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 4fded78 to 50877b3 Compare April 13, 2026 06:14
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from b653bdc to 605ab6a Compare April 13, 2026 06:14
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from 50877b3 to e344647 Compare April 13, 2026 06:54
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 50c87cb to e0c2e72 Compare April 13, 2026 07:31
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from e344647 to 48f186d Compare April 13, 2026 07:31
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from e0c2e72 to 30bf5e0 Compare April 13, 2026 08:22
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from 48f186d to 0862f54 Compare April 13, 2026 08:22

@YairVaknin-starkware YairVaknin-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@YairVaknin-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).

@graphite-app
graphite-app Bot changed the base branch from 03-21-feat_create_and_use_virtualmachineconfig to graphite-base/2370 April 20, 2026 06:35
@dorimedini-starkware
dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 30bf5e0 to 71c2029 Compare April 20, 2026 07:18
@graphite-app
graphite-app Bot changed the base branch from graphite-base/2370 to main April 20, 2026 07:18
@graphite-app

graphite-app Bot commented Apr 20, 2026

Copy link
Copy Markdown

Merge activity

  • Apr 20, 7:18 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware
dorimedini-starkware added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit dc8971a Apr 20, 2026
122 of 143 checks passed
@dorimedini-starkware
dorimedini-starkware deleted the 03-21-feat_make_max_traceback_entries_configurable branch April 20, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants