Remove unused variables in storage.rs

[AaronAjose]

Removes three unused variables (members_struct_code, members_struct_code_mut, members_init_code) that were created, populated, and passed to RewriteNode::interpolate_patched but never referenced in the template string (lines 80-116).

The template only uses $storage_base_code$, $storage_struct_members$, $substorage_members_struct_code$, and $substorage_members_init_code$ — the three removed variables had no corresponding placeholders.

[reviewable-StarkWare]

This change is 

[orizi]

@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @AaronAjose).

---

crates/cairo-lang-starknet/src/plugin/storage.rs line 54 at r1 (raw file):

        }
        let SimpleMemberGeneratedCode { storage_member, .. } =
            get_simple_member_code(db, &member, config, metadata);

SimpleMemberGeneratedCode seems like a useless struct now - change the code accordingly.

Code quote:

        let SimpleMemberGeneratedCode { storage_member, .. } =
            get_simple_member_code(db, &member, config, metadata);

[AaronAjose]

@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @AaronAjose).

crates/cairo-lang-starknet/src/plugin/storage.rs line 54 at r1 (raw file):

        }
        let SimpleMemberGeneratedCode { storage_member, .. } =
            get_simple_member_code(db, &member, config, metadata);

SimpleMemberGeneratedCode seems like a useless struct now - change the code accordingly.

Code quote:

        let SimpleMemberGeneratedCode { storage_member, .. } =
            get_simple_member_code(db, &member, config, metadata);

Hi @orizi
Done. Removed the SimpleMemberGeneratedCode struct and refactored get_simple_member_code to directly return RewriteNode<'db>

[orizi]

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AaronAjose).

---

crates/cairo-lang-starknet/src/plugin/storage.rs line 199 at r2 (raw file):

    db: &'db dyn Database,
    member: &ast::Member<'db>,
    _config: &StorageMemberConfig,

remove as well.

[AaronAjose]

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AaronAjose).

crates/cairo-lang-starknet/src/plugin/storage.rs line 199 at r2 (raw file):

    db: &'db dyn Database,
    member: &ast::Member<'db>,
    _config: &StorageMemberConfig,

remove as well.

Done. Removed the unused _config parameter.

[orizi]

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AaronAjose).

---

a discussion (no related file):
@TomerStarkware for 2nd eye.

[orizi]

@orizi made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AaronAjose).

---

a discussion (no related file):
as you can see - ./scripts/clippy.sh and ./scripts/rust_fmt.sh fails.
please make sure to checkout and run both.

[TomerStarkware]

@TomerStarkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AaronAjose).

[AaronAjose]

Fixed CI issues (removed unused imports: QueryAttrs, StorageMemberConfig, FLAT_ATTR)

[orizi]

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AaronAjose).