Fixed cost of local_into_box cost.
#9396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
requested review from
TomerStarkware,
ilyalesokhin-starkware and
liorgold2
This was referenced Jan 4, 2026
Collaborator
Author
5 tasks
5 tasks
orizi
force-pushed
the
orizi/01-04-fixed_cost_of_local_into_box_cost
branch
from
de53850 to
9f31b76
Compare
orizi
force-pushed
the
orizi/01-04-refactored_box_getting_libfuncs_by_cellexpression_add_with_const_
branch
from
b275fd7 to
dd8b310
Compare
TomerStarkware
approved these changes
Jan 4, 2026
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @liorgold2).
1 task
orizi
force-pushed
the
orizi/01-04-refactored_box_getting_libfuncs_by_cellexpression_add_with_const_
branch
from
dd8b310 to
26aa831
Compare
orizi
force-pushed
the
orizi/01-04-fixed_cost_of_local_into_box_cost
branch
from
9f31b76 to
c0ecad6
Compare
SIERRA_UPDATE_PATCH_CHANGE_TAG=Not yet released libfunc.
orizi
changed the base branch from
orizi/01-04-refactored_box_getting_libfuncs_by_cellexpression_add_with_const_
to
graphite-base/9396
orizi
force-pushed
the
graphite-base/9396
branch
from
26aa831 to
3fd8d15
Compare
orizi
force-pushed
the
orizi/01-04-fixed_cost_of_local_into_box_cost
branch
from
c0ecad6 to
0cd2a74
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduced the gas cost for the
box::local_intolibfunc from 3 steps to 2 steps. This change is reflected in the core libfunc cost calculation and updates the expected function costs in the box e2e tests.Type of change
Please check one:
Why is this change needed?
The
box::local_intolibfunc was using more gas steps than necessary. After analysis, it was determined that 2 steps is sufficient for this operation, which will reduce the gas cost for functions using this libfunc.What was the behavior or documentation before?
The
box::local_intolibfunc was costing 3 gas steps, which resulted in higher function costs in the e2e tests.What is the behavior or documentation after?
The
box::local_intolibfunc now costs 2 gas steps, reducing the overall gas cost for functions that use this operation. The e2e test function costs have been updated to reflect this change, with most functions seeing a 100-unit reduction in cost.