feat(metrics): add incremental mode logic #9402
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incremental mode isn't implemented yet in the cairo compiler, so this is disabled for now with an error message. However, once implemented, the logic is already in place. An example projects, perpetual, was added as a vendored copy, sans .git. It includes a cairo-project stub, and patch files ready for compilation. Note that this incremental logic was tested under a local scarb implementation, but currently it can no longer be tested since we have no incremental compilation.
|
This change is |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Benchmark Comparison |
giladchase
commented
Jan 4, 2026
Contributor
Author
giladchase
left a comment
giladchase
left a comment
There was a problem hiding this comment.
Wasn't sure about adding this one, since it's adding a disabled feature (incremental compilation, which isn't supported in cairo yet), but wanted to have it recorded at least. However, this can be closed without logically affecting the rest of the stack (maybe minor stuff). Once incremental is added to cairo, this can be used without much changes.
@giladchase made 1 comment.
Reviewable status: 0 of 147 files reviewed, all discussions resolved.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Incremental mode isn't implemented yet in the cairo compiler, so this is disabled for now with an
error message. However, once implemented, the logic is already in place.
An example projects, perpetual, was added as a vendored copy, sans .git.
It includes a cairo-project stub, and patch files ready for compilation.
Note that this incremental logic was tested under a local scarb implementation, but currently it can
no longer be tested since we have no incremental compilation.
Type of change
Please check one:
Why is this change needed?
What was the behavior or documentation before?
What is the behavior or documentation after?
Related issue or discussion (if any)
Additional context