Skip to content

fix: emit diagnostic for member access on unreduced impl type instead of panicking #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orizi wants to merge 1 commit into
base: orizi/03-31-fix_unsupported_items_in_statement_position
Choose a base branch
from
+46 −8
Open

fix: emit diagnostic for member access on unreduced impl type instead of panicking #9807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions crates/cairo-lang-semantic/src/expr/compute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use std::ops::Deref;
use std::sync::Arc;

use ast::PathSegment;
use cairo_lang_debug::DebugWithDb;
use cairo_lang_defs::db::{DefsGroup, get_all_path_leaves, validate_attributes_flat};
use cairo_lang_defs::diagnostic_utils::StableLocation;
use cairo_lang_defs::ids::{
Expand Down Expand Up @@ -3961,17 +3960,16 @@ fn member_access_expr<'db>(
TypeLongId::Closure(_) => {
Err(ctx.diagnostics.report(rhs_syntax.stable_ptr(db), Unsupported))
}
TypeLongId::ImplType(impl_type_id) => {
unreachable!("Impl type should've been reduced {:?}.", impl_type_id.debug(ctx.db))
}
TypeLongId::Var(_) => Err(ctx.diagnostics.report(
rhs_syntax.stable_ptr(db),
InternalInferenceError(InferenceError::TypeNotInferred(long_ty.intern(ctx.db))),
)),
TypeLongId::GenericParameter(_) | TypeLongId::Coupon(_) => Err(ctx.diagnostics.report(
rhs_syntax.stable_ptr(db),
TypeHasNoMembers { ty: long_ty.intern(ctx.db), member_name },
)),
TypeLongId::ImplType(_) | TypeLongId::GenericParameter(_) | TypeLongId::Coupon(_) => {
Err(ctx.diagnostics.report(
rhs_syntax.stable_ptr(db),
TypeHasNoMembers { ty: long_ty.intern(ctx.db), member_name },
))
}
TypeLongId::Missing(diag_added) => Err(*diag_added),
}
}
Expand Down
40 changes: 40 additions & 0 deletions crates/cairo-lang-semantic/src/expr/test_data/structure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,43 @@ error[E2023]: Base struct has no effect, all the fields in the struct have alrea
--> lib.cairo:5:15
A { a: 4, ..a }
^^^

//! > ==========================================================================

//! > Member access on unreduced impl associated type.

//! > test_runner_name
test_function_diagnostics(expect_diagnostics: true)

//! > function_code
fn foo() {}

//! > function_name
foo

//! > module_code
struct S {
val: felt252,
}

trait T<X> {
type A;
fn f(self: @X) -> Self::A;
}

impl I of T<S> {
type A = S;
fn f(self: @S) -> S {
S { val: 0 }
}
}

fn g<X, impl H: T<X>>(x: @X) -> felt252 {
H::f(x).val
}

//! > expected_diagnostics
error[E2057]: Type "H::A" has no members.
--> lib.cairo:18:13
H::f(x).val
^^^
Loading