Conversation
|
This change is |
5 tasks
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 31, 2026
Merged
eytan-starkware
approved these changes
Mar 31, 2026
Contributor
eytan-starkware
left a comment
eytan-starkware
left a comment
There was a problem hiding this comment.
@eytan-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on TomerStarkware).
TomerStarkware
approved these changes
Apr 1, 2026
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed all commit messages and made 1 comment.
Reviewable status:
orizi
changed the base branch from
orizi/03-31-fix_member_access_on_unreduced_impl_type
to
graphite-base/9808
orizi
force-pushed
the
graphite-base/9808
branch
from
64b11af to
e87ae95
Compare
orizi
force-pushed
the
orizi/03-31-fix_missing_return_type_in_loop_body
branch
from
b495f1a to
e43c38a
Compare
orizi
commented
Apr 1, 2026
Collaborator
Author
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a panic that occurred when loop expressions were used in fixed-size array size positions by handling the case where no return type context is available and providing appropriate error diagnostics.
Type of change
Please check one:
Why is this change needed?
The compiler was panicking when encountering loop expressions in array size positions because
get_return_type()would returnNone(since loops in array size positions are outside function/loop contexts), but the code was callingunwrap()on thisNonevalue.What was the behavior or documentation before?
The compiler would panic with an unwrap error when processing loop expressions in fixed-size array size positions, preventing proper error reporting.
What is the behavior or documentation after?
The compiler now gracefully handles this invalid usage by using a missing type when no return type context is available, allowing the semantic analysis to continue and report appropriate error diagnostics about type mismatches and invalid array sizes.
Related issue or discussion (if any)
Fixes #9787
Additional context
The fix includes a test case demonstrating the improved error handling for the specific case of
fn f() -> [felt252; for _ in 0..1_u32 {}], which now produces clear error messages instead of panicking.Note
Low Risk
Small, localized change in semantic loop-body handling plus a test; primary risk is subtle changes in diagnostics/type inference for loops in unusual contexts.
Overview
Fixes a semantic-analysis panic in
compute_loop_body_semanticby handling a missing return-type context (when a loop appears outside function/loop contexts, e.g. in fixed-size array length expressions) and substitutingTypeId::missingto avoid cascading failures.Adds a regression test to
expr/test_data/fixed_size_arraycoveringfn f() -> [felt252; for _ in 0..1_u32 {}]and asserting proper diagnostics are emitted instead of crashing.Written by Cursor Bugbot for commit e43c38a. This will update automatically on new commits. Configure here.