fix: emit diagnostic for non-type numeric literal suffix instead of panicking

[orizi]

Summary

Replace panic with proper error handling when encountering non-type identifiers in numeric literal type suffixes. The try_get_ty_by_name function now returns a SemanticDiagnosticKind::NotAType error instead of panicking when a type suffix is not actually a type.

---

Type of change

Please check one:

• Bug fix (fixes incorrect behavior)
• New feature
• Performance improvement
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

---

Why is this change needed?

The compiler was panicking when encountering numeric literals with non-type suffixes (e.g., 1_boolean where boolean is not a valid type). This caused the compiler to crash instead of providing a proper diagnostic message to the user.

---

What was the behavior or documentation before?

When a numeric literal had a suffix that wasn't a valid type, the compiler would panic with a message like "boolean is not a type."

---

What is the behavior or documentation after?

The compiler now gracefully handles this error case by emitting a proper diagnostic error "Not a type." (error code E2011) and continues compilation instead of crashing.

---

Related issue or discussion (if any)

Fixes #9791

---

Additional context

The change includes a test case that verifies the new error handling behavior with 1_boolean as an example of a numeric literal with an invalid type suffix.

---

Note

Low Risk
Low risk: replaces a panic with returning SemanticDiagnosticKind::NotAType, primarily affecting error reporting paths and covered by a new regression test.

Overview
Prevents a panic in try_get_ty_by_name when a name resolves to a non-type (e.g., an impl or other module item) by returning SemanticDiagnosticKind::NotAType instead.

Adds a new literal diagnostics test ensuring 1_boolean produces error E2011: Not a type rather than crashing.

^{Written by Cursor Bugbot for commit fca4f70. This will update automatically on new commits. Configure here.}

[orizi]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: handle mismatched generic param kinds in substitution rewriter instead of panicking #9815
• fix: allow statement-level consts in named argument shorthand instead of panicking #9814
• fix: use Terminal::text() for modifier text to avoid panic on malformed attribute args #9813
• fix: handle missing struct field in const evaluation instead of panicking #9812
• fix: emit diagnostic for unsupported extern fn in const evaluation instead of panicking #9811
• fix: emit diagnostic for non-type numeric literal suffix instead of panicking #9810 👈 (View in Graphite)
• fix: return None for macro rule with missing param kind instead of panicking #9809
• fix: handle missing return type context in loop body instead of panicking #9808
• fix: emit diagnostic for member access on unreduced impl type instead of panicking #9807
• fix: emit diagnostic for unsupported items in statement position instead of panicking #9806
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[eytan-starkware]

@eytan-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on orizi and TomerStarkware).

---

crates/cairo-lang-semantic/src/expr/test_data/literal line 36 at r1 (raw file):

//! > expected_diagnostics
error[E2011]: Not a type.

Bad diagnostic