Skip to content

fix: emit diagnostic for non-type numeric literal suffix instead of panicking #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orizi wants to merge 1 commit into
base: orizi/03-31-fix_macro_rule_missing_param_kind
Choose a base branch
from
Open

fix: emit diagnostic for non-type numeric literal suffix instead of panicking #9810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cairo-lang-semantic/src/corelib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ pub fn try_get_ty_by_name<'db>(
}
_ => GenericTypeId::option_from(module_item_id),
}
.unwrap_or_else(|| panic!("{} is not a type.", name.long(db)));
.ok_or(SemanticDiagnosticKind::NotAType)?;

Ok(semantic::TypeLongId::Concrete(semantic::ConcreteTypeId::new(
db,
Expand Down
21 changes: 21 additions & 0 deletions crates/cairo-lang-semantic/src/expr/test_data/literal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,24 @@ error[E2008]: A numeric literal of type core::pedersen::Pedersen cannot be creat
--> lib.cairo:2:14
let _a = 'a'_Pedersen;
^^^^^^^^^^^^

//! > ==========================================================================

//! > Numeric literal with a non-type suffix.

//! > test_runner_name
test_function_diagnostics(expect_diagnostics: true)

//! > function_code
fn foo() {
let _x = 1_boolean;
}

//! > function_name
foo

//! > expected_diagnostics
error[E2011]: Not a type.
--> lib.cairo:2:14
let _x = 1_boolean;
^^^^^^^^^
Loading