Skip to content

add disk cleanup to tests stage #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuvalsw merged 1 commit into from
Dec 23, 2025
Merged

add disk cleanup to tests stage #272

yuvalsw merged 1 commit into from
Dec 23, 2025

Conversation

@nitsan-starkware
Copy link
Contributor

@nitsan-starkware nitsan-starkware commented Dec 22, 2025 •
edited by RoeiE-starkware
Loading

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@nitsan-starkware nitsan-starkware mentioned this pull request Dec 22, 2025
Merged
9 tasks
@nitsan-starkware Graphite App
Copy link
Contributor Author

nitsan-starkware commented Dec 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nitsan-starkware nitsan-starkware mentioned this pull request Dec 22, 2025
Open
9 tasks
@nitsan-starkware nitsan-starkware marked this pull request as ready for review December 22, 2025 09:13
YairVaknin-starkware
YairVaknin-starkware reviewed Dec 22, 2025
View reviewed changes
Copy link
Contributor

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls send a link to the failure this solves?

@YairVaknin-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @phil-starkware).

nitsan-starkware
nitsan-starkware commented Dec 22, 2025
View reviewed changes
Copy link
Contributor Author

@nitsan-starkware nitsan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/starkware-libs/proving-utils/runs/58684384855

@nitsan-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @phil-starkware).

yuvalsw
yuvalsw approved these changes Dec 23, 2025
View reviewed changes
Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yuvalsw reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @phil-starkware).

@yuvalsw yuvalsw merged commit 1815697 into main Dec 23, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YairVaknin-starkware YairVaknin-starkware YairVaknin-starkware left review comments

@yuvalsw yuvalsw yuvalsw approved these changes

@phil-starkware phil-starkware Awaiting requested review from phil-starkware

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nitsan-starkware @yuvalsw @YairVaknin-starkware