Skip to content

Conversation

@noam-starkware
Copy link
Contributor

@noam-starkware noam-starkware commented Feb 3, 2026

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

Copy link
Contributor

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YairVaknin-starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noam-starkware).


.github/workflows/upload_artifacts_workflow.yml line 6 at r1 (raw file):

  push:
    branches:
      - noamp/applicative_bootloader_hints_extract_hash_func

blocking till merge-ready.

Code quote:

noamp/applicative_bootloader_hints_extract_hash_func

crates/cairo-program-runner-lib/src/hints/applicative_bootloader_hints.rs line 112 at r1 (raw file):

            .aggregator_task
            .program_hash_function,
    );

Maybe insert this first and avoid cloning the entire input?

Code quote:

    exec_scopes.insert_value(
        vars::PROGRAM_HASH_FUNCTION,
        applicative_bootloader_input
            .aggregator_task
            .program_hash_function,
    );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants