Add build_function_implicit_args helper

[naor-starkware]

Type

• feature
• bugfix
• dev (no functional changes, no API changes)
• fmt (formatting, renaming)
• build
• docs
• testing

Description

Breaking changes?

• yes
• no

---

This change is 

[OmriEshhar1]

@OmriEshhar1 reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @naor-starkware).

---

a discussion (no related file):
fix conflicts and failed tests

---

a discussion (no related file):
please get @YairVaknin-starkware (or someone else that knows this code) review it.

---

crates/cairo-program-runner/src/bin/cairo_program_runner/main.rs line 16 at r2 (raw file):

use cairo_vm::vm::errors::cairo_run_errors::CairoRunError;
use clap::Parser;
use tempfile::NamedTempFile;

revert changes in this file (add / remove empty lines).

[OmriEshhar1]

@OmriEshhar1 made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @naor-starkware).

---

crates/cairo-program-runner-lib/src/utils.rs line 136 at r2 (raw file):

    Ok(())
}
// Builds the implicit arguments (builtin pointers, syscall_ptr) for a specific Cairo function

add empty line above
and add missing / at the beginning of the line

[OmriEshhar1]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @naor-starkware and @YairVaknin-starkware).

[naor-starkware]

@naor-starkware made 2 comments.
Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @OmriEshhar1 and @YairVaknin-starkware).

---

crates/cairo-program-runner/src/bin/cairo_program_runner/main.rs line 16 at r2 (raw file):

Previously, OmriEshhar1 wrote…

revert changes in this file (add / remove empty lines).

Done.

---

crates/cairo-program-runner-lib/src/utils.rs line 136 at r2 (raw file):

Previously, OmriEshhar1 wrote…

add empty line above
and add missing / at the beginning of the line

Done.

[OmriEshhar1]

@OmriEshhar1 reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @naor-starkware and @YairVaknin-starkware).

---

crates/cairo-program-runner/src/bin/cairo_program_runner/main.rs line 16 at r2 (raw file):

Previously, naor-starkware wrote…

Done.

there's still a diff (add empty line above parse_bool() function)

---

crates/cairo-program-runner-lib/src/utils.rs line 136 at r2 (raw file):

Previously, naor-starkware wrote…

Done.

there's still a missing / (the first line of the documentation should start with ///, not //).

[OmriEshhar1]

@OmriEshhar1 reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @naor-starkware and @YairVaknin-starkware).

[OmriEshhar1]

@OmriEshhar1 resolved 1 discussion.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @naor-starkware and @YairVaknin-starkware).