tmp fixes: * apollo_network: ping and disconnect on failure (#10200) #10304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Artifacts upload workflows: |
|
This change is |
This was referenced Nov 20, 2025
Contributor
Author
|
Benchmark movements: tree_computation_flow performance regressed! tree_computation_flow time: [14.870 ms 14.980 ms 15.093 ms] change: [+1.3417% +2.9372% +4.5280%] (p = 0.00 < 0.05) Performance has regressed. Found 6 outliers among 100 measurements (6.00%) 6 (6.00%) high mild --- ❌ CI WILL FAIL: Benchmarks exceeded 8.0% regression threshold ERROR: full_committer_flow regressed by 14.450%, exceeding 8.0% threshold! full_committer_flow performance regressed! full_committer_flow time: [17.135 ms 17.431 ms 17.735 ms] change: [+12.140% +14.450% +16.538%] (p = 0.00 < 0.05) Performance has regressed. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild |
sirandreww-starkware
changed the base branch from
09-30-apollo_network_using_propeller
to
graphite-base/10304
sirandreww-starkware
force-pushed
the
graphite-base/10304
branch
from
c3a6b3c to
5125bb4
Compare
sirandreww-starkware
force-pushed
the
11-19-tmp_fixes
branch
from
f5233db to
0df8ddc
Compare
sirandreww-starkware
changed the base branch from
graphite-base/10304
to
09-30-apollo_network_using_propeller
sirandreww-starkware
force-pushed
the
11-19-tmp_fixes
branch
from
0df8ddc to
f8a2f27
Compare
sirandreww-starkware
force-pushed
the
09-30-apollo_network_using_propeller
branch
from
5125bb4 to
9c98d89
Compare
sirandreww-starkware
changed the base branch from
09-30-apollo_network_using_propeller
to
graphite-base/10304
sirandreww-starkware
force-pushed
the
graphite-base/10304
branch
from
9c98d89 to
296599d
Compare
sirandreww-starkware
force-pushed
the
11-19-tmp_fixes
branch
from
f8a2f27 to
7fe7870
Compare
sirandreww-starkware
changed the base branch from
graphite-base/10304
to
09-30-apollo_network_using_propeller
* apollo_network: ping and disconnect on failure (#10200)
sirandreww-starkware
force-pushed
the
11-19-tmp_fixes
branch
from
7fe7870 to
e15cd4e
Compare
sirandreww-starkware
force-pushed
the
09-30-apollo_network_using_propeller
branch
from
296599d to
5b2fc01
Compare
sirandreww-starkware
changed the base branch from
09-30-apollo_network_using_propeller
to
graphite-base/10304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmp fixes:
apollo_network: constant dialing fix (#10144)