-
Notifications
You must be signed in to change notification settings - Fork 65
release: upgrade to rust 1.91.1 #10468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: upgrade to rust 1.91.1 #10468
Conversation
Signed-off-by: Dori Medini <[email protected]>
dan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-starkware reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_api/src/data_availability.rs line 13 at r2 (raw file):
#[serde(try_from = "Deserializer")] pub enum DataAvailabilityMode { #[cfg_attr(any(test, feature = "testing"), default)]
This is due to clippy?
I actually liked it better before..
Code quote:
#[cfg_attr(any(test, feature = "testing"), derive(Default))]
#[serde(try_from = "Deserializer")]
pub enum DataAvailabilityMode {
#[cfg_attr(any(test, feature = "testing"), default)]bf62494 to
4a80805
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @dorimedini-starkware)
crates/starknet_api/src/data_availability.rs line 13 at r2 (raw file):
Previously, dan-starkware wrote…
This is due to clippy?
I actually liked it better before..
clippy edits out all impl Default for MyEnum that can be done with #[default], apparently.
can't see anything in the clippy changelogs or rust changelogs though...
I agree that it's not as nice but I prefer outsourcing style decisions to popular tooling, rather than talking about style
4a80805 to
05ea47d
Compare
Signed-off-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
05ea47d to
b74275e
Compare
dan-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-starkware reviewed 7 of 7 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
e70dc23
No description provided.