Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-starkware reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_api/src/data_availability.rs line 13 at r2 (raw file):

#[serde(try_from = "Deserializer")]
pub enum DataAvailabilityMode {
    #[cfg_attr(any(test, feature = "testing"), default)]

This is due to clippy?
I actually liked it better before..

Code quote:

#[cfg_attr(any(test, feature = "testing"), derive(Default))]
#[serde(try_from = "Deserializer")]
pub enum DataAvailabilityMode {
    #[cfg_attr(any(test, feature = "testing"), default)]

@dorimedini-starkware dorimedini-starkware force-pushed the dori-rust-1.91.1 branch 2 times, most recently from bf62494 to 4a80805 Compare November 27, 2025 17:07
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @dorimedini-starkware)


crates/starknet_api/src/data_availability.rs line 13 at r2 (raw file):

Previously, dan-starkware wrote…

This is due to clippy?
I actually liked it better before..

clippy edits out all impl Default for MyEnum that can be done with #[default], apparently.
can't see anything in the clippy changelogs or rust changelogs though...
I agree that it's not as nice but I prefer outsourcing style decisions to popular tooling, rather than talking about style

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dan-starkware reviewed 7 of 7 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 30, 2025
Merged via the queue into main-v0.14.1-committer with commit e70dc23 Nov 30, 2025
42 of 46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants