-
Notifications
You must be signed in to change notification settings - Fork 65
blockifier_test_utils: add inner deploy failure test function in test contract #10795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e761f91 to
da97811
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 4 of 4 files at r1.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)
crates/blockifier_test_utils/resources/feature_contracts/cairo1/test_contract.cairo line 530 at r1 (raw file):
match syscalls::call_contract_syscall( self_address, deploy_and_fail_selector,
You can use the selector! macro instead of passing it
Code quote:
deploy_and_fail_selector,crates/starknet_os_flow_tests/src/tests.rs line 2032 at r4 (raw file):
test_manager.execute_test_with_default_block_contexts(&TestParameters::default()).await; test_output.perform_default_validations(); }
Where do you check that the tx is not reverted? (and in general, in OS tests)
Code quote:
// Run the test and verify storage changes.
let test_output =
test_manager.execute_test_with_default_block_contexts(&TestParameters::default()).await;
test_output.perform_default_validations();
}cd322c0 to
3ab4aa2
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2032 at r4 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Where do you check that the tx is not reverted? (and in general, in OS tests)
Signed-off-by: Dori Medini <[email protected]>
3ab4aa2 to
f41cdf3
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 1 of 2 files at r5, 2 of 3 files at r7, 2 of 3 files at r9, 7 of 7 files at r10, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)

blockifier_test_utils: add inner deploy failure test function in test contract
starknet_os_flow_tests: add flow test for inner deploy cairo1 revert
Signed-off-by: Dori Medini [email protected]