Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

blockifier_test_utils: add inner deploy failure test function in test contract

starknet_os_flow_tests: add flow test for inner deploy cairo1 revert

Signed-off-by: Dori Medini [email protected]

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review December 15, 2025 11:19
@dorimedini-starkware dorimedini-starkware force-pushed the 11-25-blockifier_test_utils_add_inner_deploy_failure_test_function_in_test_contract branch from e761f91 to da97811 Compare December 15, 2025 11:28
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 4 of 4 files at r1.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)


crates/blockifier_test_utils/resources/feature_contracts/cairo1/test_contract.cairo line 530 at r1 (raw file):

        match syscalls::call_contract_syscall(
            self_address,
            deploy_and_fail_selector,

You can use the selector! macro instead of passing it

Code quote:

deploy_and_fail_selector,

crates/starknet_os_flow_tests/src/tests.rs line 2032 at r4 (raw file):

        test_manager.execute_test_with_default_block_contexts(&TestParameters::default()).await;
    test_output.perform_default_validations();
}

Where do you check that the tx is not reverted? (and in general, in OS tests)

Code quote:

    // Run the test and verify storage changes.
    let test_output =
        test_manager.execute_test_with_default_block_contexts(&TestParameters::default()).await;
    test_output.perform_default_validations();
}

@dorimedini-starkware dorimedini-starkware force-pushed the 11-25-blockifier_test_utils_add_inner_deploy_failure_test_function_in_test_contract branch 3 times, most recently from cd322c0 to 3ab4aa2 Compare December 15, 2025 13:08
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)


crates/starknet_os_flow_tests/src/tests.rs line 2032 at r4 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Where do you check that the tx is not reverted? (and in general, in OS tests)

in verify_execution_outputs

@dorimedini-starkware dorimedini-starkware force-pushed the 11-25-blockifier_test_utils_add_inner_deploy_failure_test_function_in_test_contract branch from 3ab4aa2 to f41cdf3 Compare December 15, 2025 13:20
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 of 2 files at r5, 2 of 3 files at r7, 2 of 3 files at r9, 7 of 7 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main-v0.14.1-committer with commit c98e942 Dec 16, 2025
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants