apollo_consensus: update consensus sim test to simulate network msg drops

[asmaastarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[asmaastarkware]

• apollo_consensus: update consensus sim test to simulate network msg drops #10869 : 2 dependent PRs (#10964 , #11016 ) 👈 (View in Graphite)
• apollo_consensus: add honest nodes consensus simulation #10868
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 1 file and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @asmaastarkware and @dafnamatsry).

---

crates/apollo_consensus/src/simulation_test.rs line 100 at r2 (raw file):

    node_votes: HashMap<Round, Vote>,
    /// The drop rate for the network.
    drop_rate: f64,

Consider keeping as 'keep_ratio', to avoid 1-P everywhere

Code quote:

drop_rate

---

crates/apollo_consensus/src/simulation_test.rs line 153 at r2 (raw file):

        let leader_id = Self::get_leader(round);

        if leader_id != *VALIDATOR_ID && self.rng.gen_bool(1.0 - self.drop_rate) {

Move this part into self.schedule

Code quote:

&& self.rng.gen_bool(1.0 - self.drop_rate)

---

crates/apollo_consensus/src/simulation_test.rs line 167 at r2 (raw file):

        for i in 1..self.validators.len() {
            let voter = self.validators[i];
            let commitment = Some(PROPOSAL_COMMITMENT);

We should have different commitments per round

Code quote:

PROPOSAL_COMMITMENT

---

crates/apollo_consensus/src/simulation_test.rs line 201 at r2 (raw file):

    fn check_and_generate_next_round(&mut self, request_round: Round) {
        if request_round > self.current_max_round {

Suggestion:

       if self.current_max_round < request_round

[asmaastarkware]

@asmaastarkware made 3 comments.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry and @matanl-starkware).

---

crates/apollo_consensus/src/simulation_test.rs line 153 at r2 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Move this part into self.schedule

Done.

---

crates/apollo_consensus/src/simulation_test.rs line 167 at r2 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

We should have different commitments per round

Done.

---

crates/apollo_consensus/src/simulation_test.rs line 201 at r2 (raw file):

    fn check_and_generate_next_round(&mut self, request_round: Round) {
        if request_round > self.current_max_round {

This just reads more naturally/readable to me..

[matanl-starkware]

@matanl-starkware reviewed 1 file and all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @asmaastarkware and @dafnamatsry).

---

crates/apollo_consensus/src/simulation_test.rs line 201 at r2 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

This just reads more naturally/readable to me..

https://github.com/rust-lang/rust-analyzer/blob/master/docs/book/src/contributing/style.md#comparisons

---

crates/apollo_consensus/src/simulation_test.rs line 170 at r3 (raw file):

                }
            }
        }

Split logic and operation

Code quote (i):

        match &event {
            InputEvent::Internal(_) => {
                self.pending_events.push(TimedEvent { tick: self.current_tick + delay, event });
            }
            _ => {
                if self.rng.gen_bool(self.keep_ratio) {
                    self.pending_events.push(TimedEvent { tick: self.current_tick + delay, event });
                }
            }
        }

Code snippet (ii):

let should_enqueue = matches!(event, InputEvent::Internal(_))
    || self.rng.gen_bool(self.keep_ratio);

if should_enqueue {
    self.pending_events.push(TimedEvent { tick: self.current_tick + delay, event });
}

[matanl-starkware]

@matanl-starkware reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry).

[matanl-starkware]

@matanl-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).

---

crates/apollo_consensus/src/simulation_test.rs line 179 at r9 (raw file):

    /// For rounds where NODE_0 is the proposer, peer votes are scheduled after
    /// the build finish event (which will be determined dynamically during simulation).
    fn pre_generate_all_rounds(&mut self) {

Most of the changes related to PR 10868.
Can you check why it happened?

Code quote:

 fn pre_generate_all_rounds

[matanl-starkware]

@matanl-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry).

[dafnamatsry]

@dafnamatsry reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware).