Skip to content

Conversation

@Itay-Tsabary-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

Itay-Tsabary-Starkware commented Jan 4, 2026

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-04-apollo_deployments_use_const_non-default_port_for_replacer_configs branch from f6df841 to fca8a2b Compare January 4, 2026 09:03
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Artifacts upload workflows:

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-04-apollo_deployments_use_const_non-default_port_for_replacer_configs branch from fca8a2b to 4047a21 Compare January 4, 2026 13:01
Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: 6 of 25 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).


crates/apollo_deployments/src/deployment_definitions.rs line 22 at r1 (raw file):

pub(crate) const INFRA_PORT_PLACEHOLDER: u16 = 1;
const_assert_ne!(INFRA_PORT_PLACEHOLDER, DEFAULT_INVALID_PORT);

Why not just use DEFAULT_INVALID_PORT?

Code quote:

pub(crate) const INFRA_PORT_PLACEHOLDER: u16 = 1;
const_assert_ne!(INFRA_PORT_PLACEHOLDER, DEFAULT_INVALID_PORT);

Copy link
Collaborator Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 6 of 25 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).


crates/apollo_deployments/src/deployment_definitions.rs line 22 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Why not just use DEFAULT_INVALID_PORT?

It has to be a different value, please see the usage in crates/apollo_deployments/src/service.rs below.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 18 files and resolved 1 discussion.
Reviewable status: 24 of 25 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Collaborator Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 25 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Jan 4, 2026
Merged via the queue into main-v0.14.1-committer with commit 88cc762 Jan 4, 2026
29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants