-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_deployments: use const non-default port for replacer configs #11379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_deployments: use const non-default port for replacer configs #11379
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f6df841 to
fca8a2b
Compare
|
Artifacts upload workflows: |
fca8a2b to
4047a21
Compare
nadin-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadin-Starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: 6 of 25 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).
crates/apollo_deployments/src/deployment_definitions.rs line 22 at r1 (raw file):
pub(crate) const INFRA_PORT_PLACEHOLDER: u16 = 1; const_assert_ne!(INFRA_PORT_PLACEHOLDER, DEFAULT_INVALID_PORT);
Why not just use DEFAULT_INVALID_PORT?
Code quote:
pub(crate) const INFRA_PORT_PLACEHOLDER: u16 = 1;
const_assert_ne!(INFRA_PORT_PLACEHOLDER, DEFAULT_INVALID_PORT);
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 6 of 25 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).
crates/apollo_deployments/src/deployment_definitions.rs line 22 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Why not just use
DEFAULT_INVALID_PORT?
It has to be a different value, please see the usage in crates/apollo_deployments/src/service.rs below.
nadin-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadin-Starkware reviewed 18 files and resolved 1 discussion.
Reviewable status: 24 of 25 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 25 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

No description provided.