Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@guy-starkware guy-starkware marked this pull request as ready for review January 4, 2026 11:50
Copy link
Contributor Author

guy-starkware commented Jan 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware force-pushed the guyn/anvil/ports_on_other_tests branch 5 times, most recently from bd59144 to 4654350 Compare January 4, 2026 15:51
@guy-starkware guy-starkware force-pushed the guyn/anvil/test_identifiers_for_ports branch from 82aeb54 to 8c829ec Compare January 5, 2026 06:54
@guy-starkware guy-starkware force-pushed the guyn/anvil/ports_on_other_tests branch from 4654350 to b2338dd Compare January 5, 2026 06:54
@guy-starkware guy-starkware force-pushed the guyn/anvil/ports_on_other_tests branch from b2338dd to 609968c Compare January 5, 2026 07:04
@guy-starkware guy-starkware force-pushed the guyn/anvil/test_identifiers_for_ports branch from 8c829ec to 213e80b Compare January 5, 2026 07:04
@guy-starkware guy-starkware force-pushed the guyn/anvil/ports_on_other_tests branch from 609968c to 7486787 Compare January 5, 2026 07:24
Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @guy-starkware).


crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 103 at r1 (raw file):

        info!("Deploying Starknet contract to Anvil with port: {}", port);
        let mut retries = 0;
        for _ in 0..100 {
  1. Where does 100 come from?
  2. We have a fn run_until utility just for this

Code quote:

        let mut retries = 0;
        for _ in 0..100 {

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).


crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 103 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…
  1. Where does 100 come from?
  2. We have a fn run_until utility just for this
  1. No reason. Could be anything.
  2. I didn't know about that! Updating.
  3. It doesn't work because the output of Starknet::deploy doesn't implement Debug (and it comes from a "sol" contract macro, I have no control over it...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants