-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_integration_tests: make sure each integration test uses a different port for Anvil #11388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_integration_tests: make sure each integration test uses a different port for Anvil #11388
Conversation
|
Artifacts upload workflows: |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bd59144 to
4654350
Compare
82aeb54 to
8c829ec
Compare
4654350 to
b2338dd
Compare
b2338dd to
609968c
Compare
8c829ec to
213e80b
Compare
…erent port for Anvil
609968c to
7486787
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @guy-starkware).
crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 103 at r1 (raw file):
info!("Deploying Starknet contract to Anvil with port: {}", port); let mut retries = 0; for _ in 0..100 {
- Where does
100come from? - We have a
fn run_untilutility just for this
Code quote:
let mut retries = 0;
for _ in 0..100 {
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).
crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 103 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
- Where does
100come from?- We have a
fn run_untilutility just for this
- No reason. Could be anything.
- I didn't know about that! Updating.
- It doesn't work because the output of Starknet::deploy doesn't implement Debug (and it comes from a "sol" contract macro, I have no control over it...)

No description provided.