apollo_storage,apollo_batcher: spawn storage reader server independently

[nadin-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nadin-Starkware]

• apollo_storage: add storage reader client #11399
• apollo_storage,apollo_batcher: spawn storage reader server independently #11392 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Merge activity

• Jan 4, 1:03 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
• Jan 4, 1:03 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-04T13:11:42Z
• Started at 2026-01-04T15:29:36Z
• Started at 2026-01-04T15:35:21Z
• Started at 2026-01-05T08:06:10Z
• Started at 2026-01-12T08:59:09Z
• Started at 2026-01-12T09:39:45Z
• Started at 2026-01-12T09:39:45Z

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).

---

crates/apollo_storage/src/storage_reader_server.rs line 178 at r2 (raw file):

            });
        }
    }

It's not a great practice to keep task handles afloat; could we somehow return the handle and store it in a relevant place?

Code quote:

    /// Spawns the storage reader server in a background task if it's enabled.
    pub fn spawn_if_enabled(server: Option<Self>)
    where
        RequestHandler: Send + Sync + 'static,
        Request: Send + Sync + 'static,
        Response: Send + Sync + 'static,
    {
        if let Some(server) = server {
            tokio::spawn(async move {
                if let Err(e) = server.run().await {
                    tracing::error!("Storage reader server error: {:?}", e);
                }
            });
        }
    }

[nadin-Starkware]

@nadin-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_storage/src/storage_reader_server.rs line 178 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

It's not a great practice to keep task handles afloat; could we somehow return the handle and store it in a relevant place?

Done.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 4 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).