Skip to content

Conversation

@nadin-Starkware
Copy link
Collaborator

No description provided.

nadin-Starkware and others added 30 commits December 30, 2025 07:12
…e reader (#11273)

* apollo_storage: split deprecate class into two functions for separate location and data retrieval

* apollo_storage:  implement deprecated declared classes query in storage reader
…11255)

* apollo_storage: split get_class into two functions for separate location and data retrieval

* apollo_storage:  implement declared classes query in storage reader
* apollo_storage: split get_casm into two functions for separate location and data retrieval

* apollo_storage:  implement csm query in storage reader
@nadin-Starkware
Copy link
Collaborator Author

Src Dst crates/apollo_consensus/src/manager.rs
Src Dst crates/apollo_consensus/src/types.rs
Src Dst crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs
Src Dst crates/apollo_state_sync/src/lib.rs
Src Dst echonet/constants.py
Src Dst echonet/deploy_echonet.py

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 47 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Contributor

@ron-starkware ron-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-starkware reviewed 2 files.
Reviewable status: 43 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeletstarkware reviewed 3 files and made 1 comment.
Reviewable status: 44 of 47 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).


crates/apollo_state_sync/src/lib.rs line 24 at r39 (raw file):

use futures::channel::mpsc::{channel, Sender};
use futures::SinkExt;
use starknet_api::block::{BlockHash, BlockNumber};

Suggestion:

use starknet_api::block::{BlockHash, BlockHeader, BlockNumber};

@nadin-Starkware nadin-Starkware force-pushed the nadin/merge-main-v0.14.1-into-main-v0.14.1-committer-1767535122 branch from c052d21 to ca6e39b Compare January 5, 2026 08:01
Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware made 1 comment.
Reviewable status: 41 of 47 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware).


crates/apollo_state_sync/src/lib.rs line 24 at r39 (raw file):

use futures::channel::mpsc::{channel, Sender};
use futures::SinkExt;
use starknet_api::block::{BlockHash, BlockNumber};

Done.

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeletstarkware resolved 1 discussion.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

@nadin-Starkware nadin-Starkware force-pushed the nadin/merge-main-v0.14.1-into-main-v0.14.1-committer-1767535122 branch from ca6e39b to 43126d4 Compare January 5, 2026 08:22
@dafnamatsry dafnamatsry force-pushed the nadin/merge-main-v0.14.1-into-main-v0.14.1-committer-1767535122 branch from 57a639b to 120621d Compare January 5, 2026 11:08
Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeletstarkware partially reviewed 2 files.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeletstarkware partially reviewed 1 file.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeletstarkware partially reviewed 1 file.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeletstarkware partially reviewed 1 file.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ayeletstarkware made 1 comment.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

@nadin-Starkware nadin-Starkware force-pushed the nadin/merge-main-v0.14.1-into-main-v0.14.1-committer-1767535122 branch 2 times, most recently from ad7447a to 7a2b146 Compare January 5, 2026 14:52
@nadin-Starkware nadin-Starkware force-pushed the nadin/merge-main-v0.14.1-into-main-v0.14.1-committer-1767535122 branch from 7a2b146 to 78f390a Compare January 5, 2026 16:51
Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Itay-Tsabary-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware partially reviewed 46 files.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 6 files.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main-v0.14.1-committer with commit a2fba92 Jan 6, 2026
31 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants