-
Notifications
You must be signed in to change notification settings - Fork 65
Merge main-v0.14.1 into main-v0.14.1-committer #11395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main-v0.14.1 into main-v0.14.1-committer #11395
Conversation
… location and data retrieval (#11272)
…ion and data retrieval (#11254)
…e reader (#11273) * apollo_storage: split deprecate class into two functions for separate location and data retrieval * apollo_storage: implement deprecated declared classes query in storage reader
…ng proposals tasks (#11238)
…11255) * apollo_storage: split get_class into two functions for separate location and data retrieval * apollo_storage: implement declared classes query in storage reader
…on and data retrieval (#11283)
* apollo_storage: split get_casm into two functions for separate location and data retrieval * apollo_storage: implement csm query in storage reader
|
Artifacts upload workflows: |
nadin-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadin-Starkware reviewed 47 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ron-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ron-starkware reviewed 2 files.
Reviewable status: 43 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware reviewed 3 files and made 1 comment.
Reviewable status: 44 of 47 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).
crates/apollo_state_sync/src/lib.rs line 24 at r39 (raw file):
use futures::channel::mpsc::{channel, Sender}; use futures::SinkExt; use starknet_api::block::{BlockHash, BlockNumber};
Suggestion:
use starknet_api::block::{BlockHash, BlockHeader, BlockNumber};c052d21 to
ca6e39b
Compare
nadin-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadin-Starkware made 1 comment.
Reviewable status: 41 of 47 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware).
crates/apollo_state_sync/src/lib.rs line 24 at r39 (raw file):
use futures::channel::mpsc::{channel, Sender}; use futures::SinkExt; use starknet_api::block::{BlockHash, BlockNumber};
Done.
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware resolved 1 discussion.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ca6e39b to
43126d4
Compare
57a639b to
120621d
Compare
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware partially reviewed 2 files.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware partially reviewed 1 file.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware partially reviewed 1 file.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware partially reviewed 1 file.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ayeletstarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayeletstarkware made 1 comment.
Reviewable status: 40 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
ad7447a to
7a2b146
Compare
7a2b146 to
78f390a
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware partially reviewed 46 files.
Reviewable status: 41 of 47 files reviewed, all discussions resolved (waiting on @nadin-Starkware).
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 6 files.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).
a2fba92
No description provided.