apollo_infra: cross component tracing lite

[victorkstarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-05T11:36:26Z
• Started at 2026-01-05T11:52:43Z
• Started at 2026-01-06T09:32:33Z
• Started at 2026-01-07T12:17:39Z
• Started at 2026-01-08T09:31:57Z
• Started at 2026-01-08T09:46:11Z
• Started at 2026-01-08T09:47:16Z
• Started at 2026-01-08T09:52:20Z
• Started at 2026-01-08T11:50:47Z
• Started at 2026-01-13T07:18:49Z

[victorkstarkware]

• apollo_infra: cross component tracing lite #11415 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_client/local_component_client.rs line 53 at r1 (raw file):

        let (res_tx, mut res_rx) = channel::<Response>(1);
        let request_id = RequestId::generate();
        info!(

debug at most, probably trace

Code quote:

info

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_client/remote_component_client.rs line 260 at r1 (raw file):

                max_attempts = max_attempts,
                "Sending remote request"
            );

Do we need a new request id per every attempt? Or could we place it before the loop?

Code quote:

            let request_id = RequestId::generate();
            info!(
                request_id = %request_id,
                request = %log_message,
                attempt = attempt,
                max_attempts = max_attempts,
                "Sending remote request"
            );

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_client/local_component_client.rs line 53 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

debug at most, probably trace

(Throughout)

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 3 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_definitions.rs line 102 at r1 (raw file):

impl RequestIdGenerator for RequestId {
    fn generate() -> RequestId {
        rand::random::<u64>()

Please avoid fully-qualified fn calls; use a use rand::random at the top of the module and then just call random here

Code quote:

 rand::random

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 4 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_definitions.rs line 98 at r1 (raw file):

pub trait RequestIdGenerator {
    fn generate() -> RequestId;
}

Why do we need this trait def? Can the fn just be part of a vanilla impl block?

Code quote:

pub trait RequestIdGenerator {
    fn generate() -> RequestId;
}

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 5 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/Cargo.toml line 23 at r1 (raw file):

hyper = { workspace = true, features = ["client", "http2", "server", "tcp"] }
metrics-exporter-prometheus.workspace = true
rand.workspace = true

Is there an std equivalent for this?

Code quote:

rand.workspace = true

[victorkstarkware]

@victorkstarkware made 5 comments.
Reviewable status: 0 of 8 files reviewed, 5 unresolved discussions (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_infra/Cargo.toml line 23 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Is there an std equivalent for this?

std::random is considered unstable. compiler points to this issue

rust-lang/rust#130703

---

crates/apollo_infra/src/component_definitions.rs line 98 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Why do we need this trait def? Can the fn just be part of a vanilla impl block?

Done.

---

crates/apollo_infra/src/component_definitions.rs line 102 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please avoid fully-qualified fn calls; use a use rand::random at the top of the module and then just call random here

Done.

---

crates/apollo_infra/src/component_client/local_component_client.rs line 53 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

(Throughout)

Done.

---

crates/apollo_infra/src/component_client/remote_component_client.rs line 260 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Do we need a new request id per every attempt? Or could we place it before the loop?

Done.

[victorkstarkware]

@victorkstarkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 5 unresolved discussions (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_infra/Cargo.toml line 23 at r1 (raw file):

Previously, victorkstarkware wrote…

random is considered unstable. compiler points to this issue

rust-lang/rust#130703

as in std::random

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 2 comments and resolved 5 discussions.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_server/remote_component_server.rs line 140 at r2 (raw file):

                // Wrap the send operation in a tokio::spawn as it is NOT a cancel-safe operation.
                // Even if the current task is cancelled, the inner task will continue to run.
                //

Please remove

Code quote:

//

---

crates/apollo_infra/src/component_server/local_component_server.rs line 398 at r2 (raw file):

        component = component_name,
        "Receiving local request"
    );

I'm not familiar with this syntax. What does it do?

Code quote:

    trace!(
        request_id = %request_id,
        request = request_label,
        component = component_name,
        "Receiving local request"
    );

[victorkstarkware]

@victorkstarkware made 2 comments.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_infra/src/component_server/local_component_server.rs line 398 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

I'm not familiar with this syntax. What does it do?

it simply adds more items to the JSON, similar to "timestamp". here is an example:

Code snippet:

{"timestamp":"2026-01-05T12:10:21.413Z","level":"INFO","message":"Receiving local request","request_id":"2748595246222769631","request":"get_transactions","component":"MempoolCommunicationWrapper","filename":"crates/apollo_infra/src/component_server/local_component_server.rs","line_number":393}

---

crates/apollo_infra/src/component_server/remote_component_server.rs line 140 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please remove

Done.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 3 unresolved discussions (waiting on @victorkstarkware).

---

crates/apollo_infra/src/component_client/remote_component_client.rs line 258 at r4 (raw file):

            trace!("Request {log_message} attempt {attempt} of {max_attempts}");
            let http_request =
                self.construct_http_request(serialized_request_bytes.clone(), request_id.clone());

Can we pass a reference here instead of cloning? It seems the passed value is used to generate a string later on, and if so, a ref should suffice.

Code quote:

request_id.clone()

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware resolved 2 discussions.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @victorkstarkware).

[victorkstarkware]

@victorkstarkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_infra/src/component_client/remote_component_client.rs line 258 at r4 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Can we pass a reference here instead of cloning? It seems the passed value is used to generate a string later on, and if so, a ref should suffice.

good point

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 8 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @victorkstarkware).

[victorkstarkware]

@victorkstarkware reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @victorkstarkware).