Skip to content

Conversation

@Yoni-Starkware
Copy link
Collaborator

…t the OS run

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Artifacts upload workflows:

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/starknet_os_flow_tests/test-builder branch from 98c4c9b to 58f5599 Compare January 5, 2026 15:58
Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware).


crates/starknet_os_flow_tests/src/tests.rs line 168 at r1 (raw file):

    // keep track of nonces.

    let (mut test_manager, _) = TestBuilder::create_standard_with_config(

please rename wherever it makes sense

Suggestion:

 test_builder

crates/starknet_os_flow_tests/src/tests.rs line 217 at r1 (raw file):

    test_manager.add_funded_account_invoke(invoke_tx_args! { calldata: deploy_contract_calldata });
    test_manager.divide_transactions_into_n_blocks(n_blocks);
    let test_output = test_manager.build().await.run();

WDYT of adding fn build_and_run to TestBuilder and use it here? (I see other places in this PR you can use it).

Code quote:

test_manager.build().await.run()

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/starknet_os_flow_tests/test-builder branch from 58f5599 to 60a365b Compare January 6, 2026 07:47
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @nimrod-starkware).


crates/starknet_os_flow_tests/src/tests.rs line 168 at r1 (raw file):

Previously, nimrod-starkware wrote…

please rename wherever it makes sense

Done.


crates/starknet_os_flow_tests/src/tests.rs line 217 at r1 (raw file):

Previously, nimrod-starkware wrote…

WDYT of adding fn build_and_run to TestBuilder and use it here? (I see other places in this PR you can use it).

Done.

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/starknet_os_flow_tests/test-builder branch from 60a365b to d7a9a27 Compare January 6, 2026 08:07
@Yoni-Starkware Yoni-Starkware changed the base branch from yoni/starknet_os_flow_tests/test-runner to main January 6, 2026 08:07
Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware).

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware).

@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit d65db53 Jan 6, 2026
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants