-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: rename TestManager to TestBuilder and move ou… #11428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Artifacts upload workflows: |
98c4c9b to
58f5599
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimrod-starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware).
crates/starknet_os_flow_tests/src/tests.rs line 168 at r1 (raw file):
// keep track of nonces. let (mut test_manager, _) = TestBuilder::create_standard_with_config(
please rename wherever it makes sense
Suggestion:
test_buildercrates/starknet_os_flow_tests/src/tests.rs line 217 at r1 (raw file):
test_manager.add_funded_account_invoke(invoke_tx_args! { calldata: deploy_contract_calldata }); test_manager.divide_transactions_into_n_blocks(n_blocks); let test_output = test_manager.build().await.run();
WDYT of adding fn build_and_run to TestBuilder and use it here? (I see other places in this PR you can use it).
Code quote:
test_manager.build().await.run()58f5599 to
60a365b
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @nimrod-starkware).
crates/starknet_os_flow_tests/src/tests.rs line 168 at r1 (raw file):
Previously, nimrod-starkware wrote…
please rename wherever it makes sense
Done.
crates/starknet_os_flow_tests/src/tests.rs line 217 at r1 (raw file):
Previously, nimrod-starkware wrote…
WDYT of adding
fn build_and_runtoTestBuilderand use it here? (I see other places in this PR you can use it).
Done.
60a365b to
d7a9a27
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimrod-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware).
…t the OS run