-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_integration_tests: unique ports for each stand-alone integration test #11433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_integration_tests: unique ports for each stand-alone integration test #11433
Conversation
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @guy-starkware).
crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 116 at r1 (raw file):
retries: {error:?}" ); });
Please apply the comments from the previous pr
Code quote:
info!("Deploying Starknet contract to Anvil with port: {}", port);
let mut retries = 0;
for _ in 0..100 {
let result = Starknet::deploy(anvil_client.clone()).await;
if result.is_ok() {
break;
}
retries += 1;
tokio::time::sleep(Duration::from_millis(10)).await;
}
Starknet::deploy(anvil_client.clone()).await.unwrap_or_else(|error| {
panic!(
"Failed to deploy Starknet contract to Anvil on port {port} after {retries} \
retries: {error:?}"
);
});
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).
crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 116 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please apply the comments from the previous pr
- Where does
100come from? -> No reason. Could be anything. - We have a
fn run_untilutility just for this-> I didn't know about that! Unfortunately, It doesn't work because the output of Starknet::deploy doesn't implement Debug (and it comes from a "sol" contract macro, I have no control over it...)
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 10 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware).
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 15 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware).
c4a9ee9

No description provided.