Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Artifacts upload workflows:

Copy link
Contributor Author

guy-starkware commented Jan 5, 2026

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @guy-starkware).


crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 116 at r1 (raw file):

                 retries: {error:?}"
            );
        });

Please apply the comments from the previous pr

Code quote:

        info!("Deploying Starknet contract to Anvil with port: {}", port);
        let mut retries = 0;
        for _ in 0..100 {
            let result = Starknet::deploy(anvil_client.clone()).await;
            if result.is_ok() {
                break;
            }
            retries += 1;
            tokio::time::sleep(Duration::from_millis(10)).await;
        }
        Starknet::deploy(anvil_client.clone()).await.unwrap_or_else(|error| {
            panic!(
                "Failed to deploy Starknet contract to Anvil on port {port} after {retries} \
                 retries: {error:?}"
            );
        });

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).


crates/apollo_base_layer_tests/src/anvil_base_layer.rs line 116 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please apply the comments from the previous pr

  • Where does 100 come from? -> No reason. Could be anything.
  • We have a fn run_until utility just for this-> I didn't know about that! Unfortunately, It doesn't work because the output of Starknet::deploy doesn't implement Debug (and it comes from a "sol" contract macro, I have no control over it...)

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Itay-Tsabary-Starkware reviewed 10 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware).

@shay-starkware shay-starkware changed the base branch from guyn/anvil/integration_test_ports to main-v0.14.1-committer January 6, 2026 12:58
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 15 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware).

@guy-starkware guy-starkware added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main-v0.14.1-committer with commit c4a9ee9 Jan 7, 2026
49 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants