workspace: add rule for comment style conventions #11520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 8, 2026
avi-starkware
approved these changes
Jan 8, 2026
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware).
AvivYossef-starkware
force-pushed
the
aviv/add-comment-style-rule
branch
from
31d704e to
c32f839
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_cursor_rule_to_run_commands_in_sequencer_venv
branch
from
cd3feef to
b8cfd71
Compare
avi-starkware
approved these changes
Jan 10, 2026
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware partially reviewed 1 file and all commit messages.
Reviewable status:
AvivYossef-starkware
changed the base branch from
aviv/add_cursor_rule_to_run_commands_in_sequencer_venv
to
main
avi-starkware
approved these changes
Jan 10, 2026
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 1 file and all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.