Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Copy link
Contributor Author

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).


crates/blockifier/src/execution/contract_class_test.rs line 266 at r1 (raw file):

    let round_tripped_hints = program_hints_to_casm_hints(program_hints).unwrap();

    // Compare with original (need to sort both for comparison).

I don't see any sort here

Code quote:

(need to sort both for comparison).

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware).


crates/blockifier/src/execution/contract_class_test.rs line 266 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

I don't see any sort here

they are both sorted the same ( with the Btree map )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants