-
Notifications
You must be signed in to change notification settings - Fork 65
blockifier: fix conversion from nested feltts counts to optional nested int list #11530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
blockifier: fix conversion from nested feltts counts to optional nested int list #11530
Conversation
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).
crates/blockifier/src/execution/contract_class.rs line 213 at r1 (raw file):
if counts.is_leaf() { None } else { Some(counts.into()) } } }
Please add this case to your round-trip test
Code quote:
impl From<&NestedFeltCounts> for Option<NestedIntList> {
fn from(counts: &NestedFeltCounts) -> Self {
// If it's a single leaf, it means the original bytecode_segment_lengths was None
if counts.is_leaf() { None } else { Some(counts.into()) }
}
}971c908 to
0f8e61b
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1).
crates/blockifier/src/execution/contract_class.rs line 213 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Please add this case to your round-trip test
Done

No description provided.