Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Copy link
Contributor Author

AvivYossef-starkware commented Jan 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).


crates/blockifier/src/execution/contract_class.rs line 213 at r1 (raw file):

        if counts.is_leaf() { None } else { Some(counts.into()) }
    }
}

Please add this case to your round-trip test

Code quote:

impl From<&NestedFeltCounts> for Option<NestedIntList> {
    fn from(counts: &NestedFeltCounts) -> Self {
        // If it's a single leaf, it means the original bytecode_segment_lengths was None
        if counts.is_leaf() { None } else { Some(counts.into()) }
    }
}

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/fix_converting_from_nested_felts_counts branch from 971c908 to 0f8e61b Compare January 8, 2026 14:44
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1).


crates/blockifier/src/execution/contract_class.rs line 213 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please add this case to your round-trip test

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants